Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2535383005: Deprecate the BASE_EMBEDDED macro (Closed)

Created:
4 years ago by Leszek Swirski
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate the BASE_EMBEDDED macro This was causing more confusion than benefit, so we're removing it. It's re-defined to empty for now, to avoid touching the ~100 files which use it, we can remove it completely during a quiet period when it's less likely to conflict with other work. Committed: https://crrev.com/80b920124cb5bd6c548b201051c13af368484c51 Cr-Commit-Position: refs/heads/master@{#41393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -34 lines) Patch
M src/allocation.h View 1 chunk +2 lines, -17 lines 0 comments Download
M src/allocation.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Leszek Swirski
This is the most painless way I could think of of "deleting" this macro.
4 years ago (2016-11-30 16:03:25 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-11-30 16:04:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535383005/1
4 years ago (2016-11-30 16:04:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 16:30:53 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-30 16:31:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80b920124cb5bd6c548b201051c13af368484c51
Cr-Commit-Position: refs/heads/master@{#41393}

Powered by Google App Engine
This is Rietveld 408576698