Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

Issue 2535383003: Collapse images disallowed by the Safe Browsing Subresource Filter. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
index 1dc79fd6d6d80020d1ff43d6eb7032e40e53be56..e655e4aa962efcf2d228b3a1cae50bc5f7a8ad08 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
@@ -133,11 +133,15 @@ void ResourceLoader::cancel() {
ResourceError::cancelledError(m_resource->lastResourceRequest().url()));
}
-void ResourceLoader::cancelForRedirectAccessCheckError(const KURL& newURL) {
+void ResourceLoader::cancelForRedirectAccessCheckError(
+ const KURL& newURL,
+ ResourceRequestBlockedReason blockedReason) {
m_resource->willNotFollowRedirect();
- if (m_loader)
- didFail(ResourceError::cancelledDueToAccessCheckError(newURL));
+ if (m_loader) {
+ didFail(
+ ResourceError::cancelledDueToAccessCheckError(newURL, blockedReason));
+ }
}
bool ResourceLoader::willFollowRedirect(
@@ -161,9 +165,10 @@ bool ResourceLoader::willFollowRedirect(
const KURL originalURL = newRequest.url();
- if (!m_fetcher->willFollowRedirect(m_resource.get(), newRequest,
- redirectResponse)) {
- cancelForRedirectAccessCheckError(newRequest.url());
+ ResourceRequestBlockedReason blockedReason = m_fetcher->willFollowRedirect(
+ m_resource.get(), newRequest, redirectResponse);
+ if (blockedReason != ResourceRequestBlockedReason::None) {
+ cancelForRedirectAccessCheckError(newRequest.url(), blockedReason);
return false;
}
@@ -174,12 +179,14 @@ bool ResourceLoader::willFollowRedirect(
// rewriting but currently we cannot. So, return false to make the
// redirect fail.
if (newRequest.url() != originalURL) {
- cancelForRedirectAccessCheckError(newRequest.url());
+ cancelForRedirectAccessCheckError(newRequest.url(),
+ ResourceRequestBlockedReason::Other);
return false;
}
if (!m_resource->willFollowRedirect(newRequest, redirectResponse)) {
- cancelForRedirectAccessCheckError(newRequest.url());
+ cancelForRedirectAccessCheckError(newRequest.url(),
+ ResourceRequestBlockedReason::Other);
return false;
}
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceLoader.h ('k') | third_party/WebKit/Source/core/html/HTMLImageElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698