Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed.html

Issue 2535383003: Collapse images disallowed by the Safe Browsing Subresource Filter. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed.html b/third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed.html
new file mode 100644
index 0000000000000000000000000000000000000000..34bcfcb9c03184e8387effcd9857d1dabaaf0250
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/http/tests/subresource_filter/image-disallowed.html
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<script src="../resources/testharness.js"></script>
+<script src="../resources/testharnessreport.js"></script>
+<body>
+<script type="text/javascript">
+// Tests that when resource loads initiated by <img> elements are disallowed,
+// the corresponding image is collapsed in the layout.
+
+if (window.testRunner) {
+ // Inject a subresource filter to disallow 'beta.png' (but not 'alpha.png').
+ testRunner.setDisallowedSubresourcePathSuffixes(["beta.png"]);
+}
+
+async_test(t => {
+ let i = document.createElement("img");
+ i.onload = t.step_func_done(_ => {
+ assert_equals(i.clientWidth, 100, "Images that are not disallowed should be displayed at their natural width.");
+ assert_equals(i.clientHeight, 100, "Images that are not disallowed should be displayed at their natural height.");
+ });
+ i.onerror = t.unreached_func();
+ i.src = "resources/alpha.png";
+ document.body.append(i);
+}, "Images whose URLs are not disallowed should still be displayed as normal.");
+
+async_test(t => {
+ let i = document.createElement("img");
+ i.onload = t.unreached_func();
+ i.onerror = t.step_func_done(_ => {
+ assert_equals(i.clientWidth, 0, "Images that are disallowed should be collapsed.");
+ assert_equals(i.clientHeight, 0, "Images that are disallowed should be collapsed.");
+ assert_equals(i.naturalWidth, 0, "Images that are disallowed should not be loaded.");
+ assert_equals(i.naturalHeight, 0, "Images that are disallowed should not be loaded.");
+ });
+ i.src = "resources/beta.png";
+ document.body.append(i);
+}, "Images whose initial URL is disallowed should not be loaded and should be collapsed in the layout.");
+
+</script>

Powered by Google App Engine
This is Rietveld 408576698