third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/fallback-image-moved-across-documents.html - Issue 2535383003: Collapse images disallowed by the Safe Browsing Subresource Filter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/fallback-image-moved-across-documents.html

Issue 2535383003: Collapse images disallowed by the Safe Browsing Subresource Filter. (Closed)

Patch Set: Phrasing. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/fallback-image-moved-across-documents-expected.html » ('j') | third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/fallback-image-moved-across-documents-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	dominicc (has gone to gerrit) 2016/12/05 03:30:55 Let's use testharness.js for new layout tests! Let's use testharness.js for new layout tests! engedy 2016/12/06 15:27:57 Done. Show quoted text On 2016/12/05 03:30:55, dominicc wrote: > Let's use testharness.js for new layout tests! Done.
	2 <iframe src="about:blank" id="nested"></iframe>

	3 <script type="text/javascript">

	4 if (window.testRunner)

	5 testRunner.waitUntilDone();

	6

	7 // Fallback content is implemented by means of shadow DOM, with a dumbed-down
	dominicc (has gone to gerrit) 2016/12/05 03:30:55 Nice comment explaining the intent of the test and Nice comment explaining the intent of the test and how it relates to the implementation. engedy 2016/12/06 15:27:57 Thanks! By the way, are tests in these folder Bli Show quoted text On 2016/12/05 03:30:55, dominicc wrote: > Nice comment explaining the intent of the test and how it relates to the > implementation. Thanks! By the way, are tests in these folder Blink-specific or are they upstreamed to any Web Platform test suites? I am not sure this test makes sense for any other rendering engine.
	8 // HTMLImageElement instance used to render the broken image icon inside.

	9 //

	10 // When such an <img> element is moved to a new document after the shadow tree

	11 // is created, care must be taken that there is no attempt to reload the broken

	12 // image icon inside, fail, and end up with infinitely nested fallback content.
	dominicc (has gone to gerrit) 2016/12/05 03:30:55 I'm curious--how would loading the broken image ic I'm curious--how would loading the broken image icon fail? engedy 2016/12/06 15:27:57 Done, I have extended the explanation. Show quoted text On 2016/12/05 03:30:55, dominicc wrote: > I'm curious--how would loading the broken image icon fail? Done, I have extended the explanation.
	13 let nestedDocument = document.getElementById("nested").contentDocument;

	14 let i = nestedDocument.createElement("img");

	15 i.onerror = function() {

	16 i.onerror = function() {

	17 if (window.testRunner)

	18 testRunner.notifyDone();

	19 };

	20 document.body.appendChild(nestedDocument.body.removeChild(i));
	dominicc (has gone to gerrit) 2016/12/05 03:30:55 Removes happen implicitly as part of apppend, appe Removes happen implicitly as part of apppend, appendChild, etc., so maybe you could simplify this by just doing document.body.append(i). engedy 2016/12/06 15:27:57 Done. Show quoted text On 2016/12/05 at 03:30:55, dominicc wrote: > Removes happen implicitly as part of apppend, appendChild, etc., so maybe you could simplify this by just doing document.body.append(i). Done.
	21 };

	22 i.src = "non-existent.png";

	23 nestedDocument.body.appendChild(i);

	24 </script>

OLD	NEW