Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Issue 2535383002: Fuzzer fix for overflow in some Lut8 profiles. (Closed)

Created:
4 years ago by msarett
Modified:
4 years ago
Reviewers:
raftias, msarett1
CC:
reviews_skia.org
Target Ref:
refs/heads/chrome/m56
Project:
skia
Visibility:
Public.

Description

Fuzzer fix for overflow in some Lut8 profiles. Bug(?) in the tetrahedral interpolation causes output values to go out of range a bit (1.035/1.0) in the upper range. We will just clamp for now as a temporary fix. BUG=668784 Change-Id: I78dd90da7174133e647b1c6c6e914dbde5de123c Reviewed-on: https://skia-review.googlesource.com/5228 Reviewed-by: Matt Sarett <msarett@google.com>; Commit-Queue: Robert Aftias <raftias@google.com>; GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2535383002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/82589494dacdc3eb562a328daa28dd2655edb787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/core/SkColorLookUpTable.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
msarett1
lgtm
4 years ago (2016-11-29 21:21:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535383002/1
4 years ago (2016-11-29 21:21:53 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-29 21:22:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/82589494dacdc3eb562a328daa28dd2655edb787

Powered by Google App Engine
This is Rietveld 408576698