Recognise x.==(null) and generate HIdentical

Recognise x.==(null) and generate HIdentical

This handles many of the kernel null-aware expansions, which do not map back to Ast nodes.

R=efortuna@google.com, sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9871523b6164c5c43db2779bc6901057723c81ae

[sra1, 2016-11-29 20:45:30]

Patchset #2 (id:20001) has been deleted

[sra1, 2016-11-29 20:46:04]

Description was changed from

==========
Recognise x.==(null) and generate HIdentical

This handles many of the null-aware expansions which do not map back to Ast
nodes.
==========

to

==========
Recognise x.==(null) and generate HIdentical

This handles many of the kernel null-aware expansions, which do not map back to
Ast nodes.
==========

[sra1, 2016-11-29 20:46:04]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2016-11-29 20:47:14]

+ 2481 | - 2185

[sra1, 2016-11-29 20:54:41]

sra@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2016-11-29 20:57:45]

lgtm

https://codereview.chromium.org/2535323002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2535323002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1501: // Handle `x == null`
specially.
can you elaborate in this comment why x == null is special?

https://codereview.chromium.org/2535323002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1522: }
consider making this code block its own function just because it's
self-contained for a specific case. (or not, your preference)

[Siggi Cherem (dart-lang), 2016-11-29 21:13:54]

lgtm, woo hoo!

[sra1, 2016-11-29 23:06:04]

Description was changed from

==========
Recognise x.==(null) and generate HIdentical

This handles many of the kernel null-aware expansions, which do not map back to
Ast nodes.
==========

to

==========
Recognise x.==(null) and generate HIdentical

This handles many of the kernel null-aware expansions, which do not map back to
Ast nodes.

R=efortuna@google.com, sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9871523b6164c5c43db2779bc6901057723c81ae
==========

[sra1, 2016-11-29 23:06:05]

Committed patchset #4 (id:80001) manually as
9871523b6164c5c43db2779bc6901057723c81ae (presubmit successful).

[sra1, 2016-11-29 23:07:18]

https://codereview.chromium.org/2535323002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2535323002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1501: // Handle `x == null`
specially.
On 2016/11/29 20:57:45, Emily Fortuna wrote:
> can you elaborate in this comment why x == null is special? 

Done.

https://codereview.chromium.org/2535323002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:1522: }
On 2016/11/29 20:57:45, Emily Fortuna wrote:
> consider making this code block its own function just because it's
> self-contained for a specific case. (or not, your preference)

Done.