Consider TextInputController::inputMethodController() could be nullptr.

Consider TextInputController::inputMethodController() could be nullptr.

The assumption that, while in layout tests, WebFrameWidget::getActiveWebInputMethodController()
always returns a (non-null) pointer is incorrect. For example, if the WebViewImpl loses focus, then the bit m_imeAcceptEvents is set to false which will stop WebViewImpl from processing any IME events.

Alternatively, if there are no focused frames within the local root
associated with WebViewImpl (i.e., focusedFrame() is null) then again there
will be no focused frames for IME and conequently, no
WebInputMethodControllers.

This patch will first rename
TextInputController()::inputMethodController() to
GetInputMethodController() and then makes sure all the references to the
method are taking potential nullptr-ness of the result into account.

BUG=668827
Committed: https://crrev.com/c75b1b3b3a1cf1e3825ea14bc0536cf96f36bd19
Cr-Commit-Position: refs/heads/master@{#435848}

[EhsanK, 2016-11-30 02:15:38]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[EhsanK, 2016-11-30 02:16:22]

ekaramad@chromium.org changed reviewers:
+ rbyers@chromium.org

[EhsanK, 2016-11-30 02:16:22]

Rick, could you please review this CL?

Thanks!

[commit-bot: I haz the power, 2016-11-30 02:16:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 04:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 04:17:50]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Rick Byers, 2016-12-02 01:49:46]

LGTM

[EhsanK, 2016-12-02 02:36:31]

Thanks for the reviews!

[EhsanK, 2016-12-02 02:36:41]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 02:37:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2016-12-02 03:00:59]

The CQ bit was unchecked by ekaramad@chromium.org

[EhsanK, 2016-12-02 03:00:59]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2016-12-02 03:01:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 03:57:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480647659580390, "parent_rev":
"9f87583b7ee2f36aa840292683f26a14a4188646", "commit_rev":
"f4eb2bb1c4e4aa3ba84a0aec41f79f138123206b"}

[commit-bot: I haz the power, 2016-12-02 03:58:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-02 04:00:25]

Description was changed from

==========
Consider TextInputController::inputMethodController() could be nullptr.

The assumption that, while in layout tests,
WebFrameWidget::getActiveWebInputMethodController()
always returns a (non-null) pointer is incorrect. For example, if the
WebViewImpl loses focus, then the bit m_imeAcceptEvents is set to false which
will stop WebViewImpl from processing any IME events.

Alternatively, if there are no focused frames within the local root
associated with WebViewImpl (i.e., focusedFrame() is null) then again there
will be no focused frames for IME and conequently, no
WebInputMethodControllers.

This patch will first rename
TextInputController()::inputMethodController() to
GetInputMethodController() and then makes sure all the references to the
method are taking potential nullptr-ness of the result into account.

BUG=668827
==========

to

==========
Consider TextInputController::inputMethodController() could be nullptr.

The assumption that, while in layout tests,
WebFrameWidget::getActiveWebInputMethodController()
always returns a (non-null) pointer is incorrect. For example, if the
WebViewImpl loses focus, then the bit m_imeAcceptEvents is set to false which
will stop WebViewImpl from processing any IME events.

Alternatively, if there are no focused frames within the local root
associated with WebViewImpl (i.e., focusedFrame() is null) then again there
will be no focused frames for IME and conequently, no
WebInputMethodControllers.

This patch will first rename
TextInputController()::inputMethodController() to
GetInputMethodController() and then makes sure all the references to the
method are taking potential nullptr-ness of the result into account.

BUG=668827

Committed: https://crrev.com/c75b1b3b3a1cf1e3825ea14bc0536cf96f36bd19
Cr-Commit-Position: refs/heads/master@{#435848}
==========

[commit-bot: I haz the power, 2016-12-02 04:00:27]

Patchset 1 (id:??) landed as
https://crrev.com/c75b1b3b3a1cf1e3825ea14bc0536cf96f36bd19
Cr-Commit-Position: refs/heads/master@{#435848}