Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2535303003: [CUPS] Fix the browser crash in CUPS settings UI in guest mode. (Closed)

Created:
4 years ago by xdai1
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] Fix the browser crash in CUPS settings UI in guest mode. The reason for the crash is that there is no PrinterPrefManager keyed service for the guest profile or incognito profile. In order to fix this, we only allow a regular profile to access the CUPS printers settings UI. BUG=667395 Committed: https://crrev.com/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec Cr-Commit-Position: refs/heads/master@{#435342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/chromeos/printing/printer_pref_manager_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
xdai1
stevenjb@, could you help review this CL please? Thanks!
4 years ago (2016-11-29 23:57:00 UTC) #2
stevenjb
lgtm
4 years ago (2016-11-30 00:05:29 UTC) #3
xdai1
On 2016/11/30 00:05:29, stevenjb wrote: > lgtm Thanks for the review!
4 years ago (2016-11-30 00:12:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535303003/1
4 years ago (2016-11-30 00:13:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-30 02:16:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535303003/1
4 years ago (2016-11-30 17:53:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 18:24:42 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-30 18:28:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/194dc32cac75a954d252d0a1b8ea4aa81eccd8ec
Cr-Commit-Position: refs/heads/master@{#435342}

Powered by Google App Engine
This is Rietveld 408576698