Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2535273003: [Offline pages] TaskQueue polishing (Closed)

Created:
4 years ago by fgorski
Modified:
4 years ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] TaskQueue polishing Applying changes to method names and documentation based on design review of the TaskQueue. BUG=651238 R=dougarnett@chromium.org,petewil@chromium.org Committed: https://crrev.com/cb1a8a81fc8788f48529a653bb32c46e7cee9c36 Cr-Commit-Position: refs/heads/master@{#435347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M components/offline_pages/core/task.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/offline_pages/core/task_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/core/task_queue.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
fgorski
PTAL there is no rush. I want to keep it open to hear others' ideas.
4 years ago (2016-11-29 23:02:02 UTC) #1
Pete Williamson
lgtm
4 years ago (2016-11-29 23:27:48 UTC) #2
dougarnett
lgtm
4 years ago (2016-11-30 00:09:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535273003/1
4 years ago (2016-11-30 17:36:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 18:29:49 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-30 18:34:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb1a8a81fc8788f48529a653bb32c46e7cee9c36
Cr-Commit-Position: refs/heads/master@{#435347}

Powered by Google App Engine
This is Rietveld 408576698