Better mirrors support for mixins and private fields

Better mirrors support for mixins and private fields

This is generally motivated by pageloader usage.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/88c5dd5745ecd4b821a00e172b485d5bf29e79c6

[vsm, 2016-11-29 17:57:47]

Description was changed from

==========
Better mirrors support for mixins and private fields

This is generally motivated by pageloader usage.
==========

to

==========
Better mirrors support for mixins and private fields

This is generally motivated by pageloader usage.
==========

[vsm, 2016-11-29 17:57:47]

vsm@google.com changed reviewers:
+ jmesserly@google.com, rnystrom@google.com

[Bob Nystrom, 2016-11-29 21:28:13]

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/lib/internal/symbol.dart (right):

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/lib/internal/symbol.dart:119: && _nativeSymbol
== other._nativeSymbol;
Run dartfmt?

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart (right):

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:486: if (mixins == null
|| mixins.length == 0) {
".length == 0" -> ".isEmpty"

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:487: _mixin = this;
What's this about? A class is its own mixin?

[vsm, 2016-11-29 21:41:05]

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/lib/internal/symbol.dart (right):

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/lib/internal/symbol.dart:119: && _nativeSymbol
== other._nativeSymbol;
On 2016/11/29 21:28:13, Bob Nystrom wrote:
> Run dartfmt?

Done.

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart (right):

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:486: if (mixins == null
|| mixins.length == 0) {
On 2016/11/29 21:28:13, Bob Nystrom wrote:
> ".length == 0" -> ".isEmpty"

Done.

https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:487: _mixin = this;
On 2016/11/29 21:28:13, Bob Nystrom wrote:
> What's this about? A class is its own mixin?

Yep.

https://api.dartlang.org/stable/1.20.1/dart-mirrors/ClassMirror/mixin.html

reflectClass(Foo) == reflectClass(Foo).mixin

if Foo isn't the result of a mixin.

[Bob Nystrom, 2016-11-29 21:53:32]

On 2016/11/29 21:41:05, vsm wrote:
>
https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
> File pkg/dev_compiler/tool/input_sdk/lib/internal/symbol.dart (right):
> 
>
https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
> pkg/dev_compiler/tool/input_sdk/lib/internal/symbol.dart:119: && _nativeSymbol
> == other._nativeSymbol;
> On 2016/11/29 21:28:13, Bob Nystrom wrote:
> > Run dartfmt?
> 
> Done.
> 
>
https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
> File pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart (right):
> 
>
https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
> pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:486: if (mixins ==
null
> || mixins.length == 0) {
> On 2016/11/29 21:28:13, Bob Nystrom wrote:
> > ".length == 0" -> ".isEmpty"
> 
> Done.
> 
>
https://codereview.chromium.org/2535273002/diff/20001/pkg/dev_compiler/tool/i...
> pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart:487: _mixin = this;
> On 2016/11/29 21:28:13, Bob Nystrom wrote:
> > What's this about? A class is its own mixin?
> 
> Yep.
> 
> https://api.dartlang.org/stable/1.20.1/dart-mirrors/ClassMirror/mixin.html
> 
> reflectClass(Foo) == reflectClass(Foo).mixin
> 
> if Foo isn't the result of a mixin.

Oh, dart:mirrors, you so crazy.

[Bob Nystrom, 2016-11-29 21:53:36]

lgtm

[vsm, 2016-11-29 22:00:10]

Description was changed from

==========
Better mirrors support for mixins and private fields

This is generally motivated by pageloader usage.
==========

to

==========
Better mirrors support for mixins and private fields

This is generally motivated by pageloader usage.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/88c5dd5745ecd4b821a00e172b485d5bf29e79c6
==========

[vsm, 2016-11-29 22:00:12]

Committed patchset #3 (id:40001) manually as
88c5dd5745ecd4b821a00e172b485d5bf29e79c6 (presubmit successful).