Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2535253002: [compiler] Remove dead code from js-generic-lowering. (Closed)

Created:
4 years ago by neis
Modified:
4 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove dead code from js-generic-lowering. JSLoadContext and JSStoreContext are always reduced in js-typed-lowering. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/000dea2fa4e79a0ab38a35793e43e74fff366761 Cr-Commit-Position: refs/heads/master@{#41380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +2 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
4 years ago (2016-11-29 16:40:32 UTC) #1
Michael Starzinger
LGTM.
4 years ago (2016-11-30 09:45:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535253002/1
4 years ago (2016-11-30 09:48:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 10:13:45 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-30 10:14:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/000dea2fa4e79a0ab38a35793e43e74fff366761
Cr-Commit-Position: refs/heads/master@{#41380}

Powered by Google App Engine
This is Rietveld 408576698