Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2535243002: Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation(). (Closed)

Created:
4 years ago by bruthig
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Disabled ink drop animations based on gfx::Animation::ShouldRenderRichAnimation(). Forces an animation duration of 0 for all ink drop animations if ShouldRenderRichAnimations() returns false. BUG=658384 Review-Url: https://codereview.chromium.org/2520353004 Cr-Commit-Position: refs/heads/master@{#434301} (cherry picked from commit 03ac98e06185f954738f1d3ec98c387b412c53f3) Committed: https://chromium.googlesource.com/chromium/src/+/146e4c96e3e45a0edb5d04f6b76d44e86cdb24f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M ui/views/animation/flood_fill_ink_drop_ripple.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/views/animation/ink_drop_highlight.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M ui/views/animation/square_ink_drop_ripple.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
bruthig
Committed patchset #1 (id:1) manually as 146e4c96e3e45a0edb5d04f6b76d44e86cdb24f7.
4 years ago (2016-11-29 15:09:16 UTC) #2
bruthig
4 years ago (2016-11-29 23:07:24 UTC) #3
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2543443002/ by bruthig@chromium.org.

The reason for reverting is: Failing tests on windows bots.  I suspect the tests
are actually dependent on environment settings which is not good and will
require time to investigate..

Powered by Google App Engine
This is Rietveld 408576698