Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2535233002: Reland of After detach, there's no document to notify parsing is finished. (Closed)

Created:
4 years ago by battre
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of After detach, there's no document to notify parsing is finished. (patchset #1 id:1 of https://codereview.chromium.org/2538473004/ ) Reason for revert: Reland, probably innocuous for crbug.com/669435 Original issue's description: > Revert of After detach, there's no document to notify parsing is finished. (patchset #3 id:40001 of https://codereview.chromium.org/2537043002/ ) > > Reason for revert: > Speculative revert for crbug.com/669435 > > Original issue's description: > > After detach, there's no document to notify parsing is finished. > > > > HTMLViewSourceParser was tripping the DCHECK in > > DocumentParser::document when it recieved the last bytes of the > > document it was parsing after it was detached. > > > > BUG=664915 > > > > Committed: https://crrev.com/8e59e2d6feaa38b37836837e996b9ad91c0b3745 > > Cr-Commit-Position: refs/heads/master@{#434937} > > TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=664915 > > Committed: https://crrev.com/ffe8e7b51df227590c9cadad11dd9e734f571129 > Cr-Commit-Position: refs/heads/master@{#434954} TBR=tkent@chromium.org,yoichio@chromium.org,yosin@chromium.org,dominicc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664915 Committed: https://crrev.com/53d659d792a55aa8244004a333fb5866a10048a2 Cr-Commit-Position: refs/heads/master@{#434972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLViewSourceDocument.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/html/parser/HTMLViewSourceParserTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
battre
Created Reland of After detach, there's no document to notify parsing is finished.
4 years ago (2016-11-29 13:20:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535233002/1
4 years ago (2016-11-29 13:20:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 13:22:13 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-29 13:23:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53d659d792a55aa8244004a333fb5866a10048a2
Cr-Commit-Position: refs/heads/master@{#434972}

Powered by Google App Engine
This is Rietveld 408576698