Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 253523004: Use base::STLSetDifference() in place of std::set_difference(). (Closed)

Created:
6 years, 8 months ago by Sungmann Cho
Modified:
6 years, 8 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use base::STLSetDifference() in place of std::set_difference(). BUG=254066 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M content/renderer/media/webrtc/media_stream_track_metrics.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sungmann Cho
Please take a look. Thanks.
6 years, 8 months ago (2014-04-25 05:09:44 UTC) #1
perkj_chrome
LGTM
6 years, 8 months ago (2014-04-25 06:48:47 UTC) #2
perkj_chrome
The CQ bit was checked by perkj@chromium.org
6 years, 8 months ago (2014-04-25 06:48:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/253523004/1
6 years, 8 months ago (2014-04-25 08:24:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 08:57:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-25 08:58:01 UTC) #6
Sungmann Cho
The chromium_presubmit fails with the message "Missing LGTM from an OWNER". But perkj@ is in ...
6 years, 8 months ago (2014-04-25 10:05:32 UTC) #7
perkj_chrome
On 2014/04/25 10:05:32, Sungmann Cho wrote: > The chromium_presubmit fails with the message "Missing LGTM ...
6 years, 8 months ago (2014-04-25 10:17:06 UTC) #8
Sungmann Cho
The CQ bit was checked by sungmann.cho@navercorp.com
6 years, 8 months ago (2014-04-25 10:22:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sungmann.cho@navercorp.com/253523004/1
6 years, 8 months ago (2014-04-25 12:59:48 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 23:45:37 UTC) #11
Message was sent while issue was closed.
Change committed as 266293

Powered by Google App Engine
This is Rietveld 408576698