Support patched generic methods.

Support patched generic methods.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/44bdc7582772ce8952eaa62b953109afcbed8ee0

[Johnni Winther, 2016-11-29 12:56:30]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-11-29 18:06:56]

lgtm

https://codereview.chromium.org/2535213003/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/patch_resolver.dart (right):

https://codereview.chromium.org/2535213003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/patch_resolver.dart:114: if
('${originTree.typeVariables}' != '${patchTree.typeVariables}') {
do we use .toString anywhere else for this kind of comparison? Could we compare
it programmatically instead?

Also, would we fail if you use different variable names, but that are equivalent
otherwise?

[Johnni Winther, 2016-11-30 08:14:29]

https://codereview.chromium.org/2535213003/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/patch_resolver.dart (right):

https://codereview.chromium.org/2535213003/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/patch_resolver.dart:114: if
('${originTree.typeVariables}' != '${patchTree.typeVariables}') {
On 2016/11/29 18:06:56, Siggi Cherem (dart-lang) wrote:
> do we use .toString anywhere else for this kind of comparison? Could we
compare
> it programmatically instead?

We also do it in [checkMatchingPatchParameters] to ensure matching default
values. We don't need to support variance to this is the easiest way to guard
against accidental mismatch.

> Also, would we fail if you use different variable names, but that are
equivalent
> otherwise? 

We would and should since the body would be resolved in a scope with the
original type variables. Test added.

[Johnni Winther, 2016-11-30 08:20:49]

Description was changed from

==========
Support patched generic methods.
==========

to

==========
Support patched generic methods.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/44bdc7582772ce8952eaa62b953109afcbed8ee0
==========

[Johnni Winther, 2016-11-30 08:20:51]

Committed patchset #3 (id:40001) manually as
44bdc7582772ce8952eaa62b953109afcbed8ee0 (presubmit successful).