components/discardable_memory/service/discardable_shared_memory_manager.cc - Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/discardable_memory/service/discardable_shared_memory_manager.cc

Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage

Patch Set: (rebase) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/discardable_memory/common/discardable_shared_memory_heap.cc ('k') | components/viz/display_compositor/host_shared_bitmap_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/discardable_memory/service/discardable_shared_memory_manager.cc

diff --git a/components/discardable_memory/service/discardable_shared_memory_manager.cc b/components/discardable_memory/service/discardable_shared_memory_manager.cc

index 0913399d492570bdccd781b9cc6850eacc26b5e8..add693c9f65d2be082dde8b7e6cebf2034a07b6b 100644

--- a/components/discardable_memory/service/discardable_shared_memory_manager.cc

+++ b/components/discardable_memory/service/discardable_shared_memory_manager.cc

@@ -330,6 +330,10 @@ bool DiscardableSharedMemoryManager::OnMemoryDump(

pmd->CreateSharedGlobalAllocatorDump(shared_segment_guid);

pmd->AddOwnershipEdge(dump->guid(), shared_segment_guid);

+// TODO(hajimehoshi): base::SharedMemoryTracker::AddOwnershipEdges should

+// be used instead of CreateSharedGlobalAllocatorDump, but the |dump|

+// doesn't have 'size' attribute here and it wouldn't make sense so far.

#if defined(COUNT_RESIDENT_BYTES_SUPPORTED)

if (args.level_of_detail ==

base::trace_event::MemoryDumpLevelOfDetail::DETAILED) {