ui/gl/gl_image_io_surface.mm - Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_image_io_surface.mm

Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage

Patch Set: (wip) Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gl/gl_image_io_surface.mm

diff --git a/ui/gl/gl_image_io_surface.mm b/ui/gl/gl_image_io_surface.mm

index 7b24aeaa67e119af7636709e6fc5ac92b09708fb..4dcb686aa9d4e71d59f3615b99d8e5bcaf7f8f6b 100644

--- a/ui/gl/gl_image_io_surface.mm

+++ b/ui/gl/gl_image_io_surface.mm

@@ -365,6 +365,9 @@ void GLImageIOSurface::OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd,

GetGenericSharedMemoryGUIDForTracing(process_tracing_id, io_surface_id_);

pmd->CreateSharedGlobalAllocatorDump(guid);

pmd->AddOwnershipEdge(dump->guid(), guid);

+ // TODO(hajimehoshi): Call

+ // base::SharedMemoryDumpProvider::AddOwnershipEdgeToSharedGlobalDump to

+ // report shared memory usage correctly.

}

bool GLImageIOSurface::EmulatingRGB() const {