Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Unified Diff: content/browser/gpu/browser_gpu_memory_buffer_manager.cc

Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage
Patch Set: (wip) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/browser_gpu_memory_buffer_manager.cc
diff --git a/content/browser/gpu/browser_gpu_memory_buffer_manager.cc b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
index 5c1d25a07576b49a0f448c552ce371aba184e75f..7dbcee6109382f2e70930962eba816e06524de8c 100644
--- a/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
+++ b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
@@ -192,6 +192,10 @@ bool BrowserGpuMemoryBufferManager::OnMemoryDump(
buffer_id);
pmd->CreateSharedGlobalAllocatorDump(shared_buffer_guid);
pmd->AddOwnershipEdge(dump->guid(), shared_buffer_guid);
+ // TODO(hajimehoshi): GpuMemoryBuffer might be allocated in SharedMemory.
+ // This depends on configuration (IsNativeGpuMemoryBufferConfiguration).
+ // Get shared memory handle of that and call
+ // base::SharedMemoryTracker::AddOwnershipEdges here when necessary.
}
}

Powered by Google App Engine
This is Rietveld 408576698