Chromium Code Reviews

Unified Diff: cc/tiles/gpu_image_decode_cache.cc

Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage
Patch Set: (wip) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « cc/test/test_shared_bitmap_manager.cc ('k') | components/discardable_memory/common/discardable_shared_memory_heap.h » ('j') | components/discardable_memory/service/discardable_shared_memory_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tiles/gpu_image_decode_cache.cc
diff --git a/cc/tiles/gpu_image_decode_cache.cc b/cc/tiles/gpu_image_decode_cache.cc
index 3ea22ba20faaea37deda12875dc380c9f21f948d..bde9821f70323bdc18d8b2d5a50dd5eb17316c7b 100644
--- a/cc/tiles/gpu_image_decode_cache.cc
+++ b/cc/tiles/gpu_image_decode_cache.cc
@@ -650,6 +650,9 @@ bool GpuImageDecodeCache::OnMemoryDump(
const int kImportance = 3;
pmd->CreateSharedGlobalAllocatorDump(guid);
pmd->AddOwnershipEdge(dump->guid(), guid, kImportance);
+ // TODO(hajimehoshi): |image_data::data_| might be allocated in
+ // DiscardableSharedMemory. Get shared memory handle of that and call
+ // base::SharedMemoryDumpProvider::AddOwnershipEdgeToSharedGlobalDump here
}
}
« no previous file with comments | « cc/test/test_shared_bitmap_manager.cc ('k') | components/discardable_memory/common/discardable_shared_memory_heap.h » ('j') | components/discardable_memory/service/discardable_shared_memory_manager.cc » ('J')

Powered by Google App Engine