components/discardable_memory/service/discardable_shared_memory_manager.cc - Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/discardable_memory/service/discardable_shared_memory_manager.cc

Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage

Patch Set: Implement buckets Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/memory/shared_memory_win.cc ('K') | « components/discardable_memory/common/discardable_shared_memory_heap.cc ('k') | content/browser/gpu/browser_gpu_memory_buffer_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/discardable_memory/service/discardable_shared_memory_manager.cc

diff --git a/components/discardable_memory/service/discardable_shared_memory_manager.cc b/components/discardable_memory/service/discardable_shared_memory_manager.cc

index a974b2d9e27d8f35d1a59a9fcc7a5e8fdfc6e0e0..81c0b1f8543ba7337d5d1738c6cc03c13118e4ee 100644

--- a/components/discardable_memory/service/discardable_shared_memory_manager.cc

+++ b/components/discardable_memory/service/discardable_shared_memory_manager.cc

@@ -16,6 +16,7 @@

#include "base/memory/discardable_memory.h"

#include "base/memory/memory_coordinator_client_registry.h"

#include "base/memory/ptr_util.h"

+#include "base/memory/shared_memory_tracker.h"

#include "base/numerics/safe_math.h"

#include "base/process/memory.h"

#include "base/strings/string_number_conversions.h"

@@ -328,6 +329,9 @@ bool DiscardableSharedMemoryManager::OnMemoryDump(

client_tracing_id, segment_id);

pmd->CreateSharedGlobalAllocatorDump(shared_segment_guid);

pmd->AddOwnershipEdge(dump->guid(), shared_segment_guid);

+ base::SharedMemoryTracker::AddOwnershipEdgeToSharedGlobalDump(

+ pmd, shared_segment_guid,

+ segment->memory()->handle(), segment->memory()->mapped_size());

#if defined(COUNT_RESIDENT_BYTES_SUPPORTED)

if (args.level_of_detail ==