Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: content/common/host_shared_bitmap_manager.cc

Issue 2535213002: [WIP] Add SharedMemoryTracker to dump base::SharedMemory usage
Patch Set: Remove unneeded calls Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/host_shared_bitmap_manager.cc
diff --git a/content/common/host_shared_bitmap_manager.cc b/content/common/host_shared_bitmap_manager.cc
index 51f4fc79160d8f6c39f84f468930c95ba0504606..dc1bc1532640d638a7ce0e2bdda8f57ad9f429f9 100644
--- a/content/common/host_shared_bitmap_manager.cc
+++ b/content/common/host_shared_bitmap_manager.cc
@@ -12,6 +12,7 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
+#include "base/memory/shared_memory_dump_provider.h"
#include "base/strings/string_number_conversions.h"
#include "base/trace_event/process_memory_dump.h"
#include "build/build_config.h"
@@ -178,6 +179,8 @@ bool HostSharedBitmapManager::OnMemoryDump(
auto guid = cc::GetSharedBitmapGUIDForTracing(bitmap.first);
pmd->CreateSharedGlobalAllocatorDump(guid);
pmd->AddOwnershipEdge(dump->guid(), guid);
+ base::SharedMemoryDumpProvider::GetInstance()->AddSuballocation(
+ pmd, dump->guid());
}
return true;
@@ -225,7 +228,7 @@ void HostSharedBitmapManager::AllocateSharedBitmapForChild(
*shared_memory_handle = base::SharedMemory::NULLHandle();
return;
}
- data->memory->Close();
+ data->memory->Close();
}
void HostSharedBitmapManager::ChildDeletedSharedBitmap(

Powered by Google App Engine
This is Rietveld 408576698