Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2535203004:
[Devtools] Fixed selection removal in FilterBar on blur (Closed)
|
Created:
4 years ago by allada Modified:
4 years ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Fixed selection removal in FilterBar on blur
Fixes a bug where if the user had data selected in a FilterBar and
blured it would remove the user's selection.
R=lushnikov,einbinder
BUG=669400
Committed: https://crrev.com/eee01aac1d6ddfb4fcdef0e2103087d5043ea3bc
Cr-Commit-Position: refs/heads/master@{#435397}
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by allada@chromium.org to run a CQ dry run
PTL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480533219175790, "parent_rev":
"b8ff497cb48210146532e2b5d40effa7e54789eb", "commit_rev":
"787ee1fb20f613826669496864e5ae1c57a736af"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fixed selection removal in FilterBar on blur Fixes a bug where if the user had data selected in a FilterBar and blured it would remove the user's selection. R=lushnikov,einbinder BUG=669400 ========== to ========== [Devtools] Fixed selection removal in FilterBar on blur Fixes a bug where if the user had data selected in a FilterBar and blured it would remove the user's selection. R=lushnikov,einbinder BUG=669400 Committed: https://crrev.com/eee01aac1d6ddfb4fcdef0e2103087d5043ea3bc Cr-Commit-Position: refs/heads/master@{#435397} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/eee01aac1d6ddfb4fcdef0e2103087d5043ea3bc Cr-Commit-Position: refs/heads/master@{#435397} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
