Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2535173009: Convert editing/selection/extend-by-word-002.html with assert_selection (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection/extend-by-word-002.html with assert_selection This patch converts the layout test with assert_selection to improve code health and also increase the usage of w3c testharness. It also moves the test file to editing/selection/modify_extend for better organization. Note: Chrome's current behavior is incorrect. It will be fixed by https://codereview.chromium.org/2541163003 BUG=n/a Committed: https://crrev.com/d177fe1ee25a0c330655c60e0092bff9cbe732bd Cr-Commit-Position: refs/heads/master@{#436223}

Patch Set 1 #

Patch Set 2 : Add platform-dependent test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -82 lines) Patch
D third_party/WebKit/LayoutTests/editing/selection/extend-by-word-002.html View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/extend-by-word-002-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_extend/extend_by_word_002.html View 1 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-05 02:26:49 UTC) #12
tkent
lgtm
4 years ago (2016-12-05 03:12:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535173009/20001
4 years ago (2016-12-05 03:13:49 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 03:17:34 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-05 03:19:24 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d177fe1ee25a0c330655c60e0092bff9cbe732bd
Cr-Commit-Position: refs/heads/master@{#436223}

Powered by Google App Engine
This is Rietveld 408576698