Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2535173007:
MD Settings: fix appearance of managed metrics reporting checkbox (Closed)
|
Created:
4 years ago by Dan Beam Modified:
4 years ago Reviewers:
dpapad CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: fix appearance of managed metrics reporting checkbox
TBR=dpapad@chromium.org
BUG=614265
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/ebca4c2dfacabe8c38cf4d7122f18334aced2f7f
Cr-Commit-Position: refs/heads/master@{#435800}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== MD Settings: fix appearance of managed metrics reporting checkbox R=dpapad@chromium.org BUG=614265 ========== to ========== MD Settings: fix appearance of managed metrics reporting checkbox R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM On Wed, Nov 30, 2016 at 8:53 PM, <dbeam@chromium.org> wrote: > Reviewers: dpapad > CL: https://codereview.chromium.org/2535173007/ > > Description: > MD Settings: fix appearance of managed metrics reporting checkbox > > R=dpapad@chromium.org > BUG=614265 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Affected files (+4, -0 lines): > M chrome/browser/resources/settings/privacy_page/privacy_page.html > > > Index: chrome/browser/resources/settings/privacy_page/privacy_page.html > diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html > b/chrome/browser/resources/settings/privacy_page/privacy_page.html > index 28792dc7750dccc8b92ba760d9377349e19c5f6a.. > a0afaa314d8083bd538f468590192919d16f065c 100644 > --- a/chrome/browser/resources/settings/privacy_page/privacy_page.html > +++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html > @@ -49,6 +49,10 @@ > #metricsReportingCheckbox, > #safeBrowsingExtendedReportingCheckbox { > display: inline-block; > + } > + > + #metricsReportingCheckbox:not([disabled]), > + #safeBrowsingExtendedReportingCheckbox { > width: 100%; > } > > > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== MD Settings: fix appearance of managed metrics reporting checkbox R=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: fix appearance of managed metrics reporting checkbox TBR=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480640435209590, "parent_rev":
"3715a819c8ed6848491f2c96ba835d02286368e6", "commit_rev":
"6a357b6d5e9491132e8af5f609e2bbc3f4b10794"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: fix appearance of managed metrics reporting checkbox TBR=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: fix appearance of managed metrics reporting checkbox TBR=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: fix appearance of managed metrics reporting checkbox TBR=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: fix appearance of managed metrics reporting checkbox TBR=dpapad@chromium.org BUG=614265 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ebca4c2dfacabe8c38cf4d7122f18334aced2f7f Cr-Commit-Position: refs/heads/master@{#435800} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ebca4c2dfacabe8c38cf4d7122f18334aced2f7f Cr-Commit-Position: refs/heads/master@{#435800} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
