third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp - Issue 2535173002: Prevent implicit framebuffer clear from clobbering alpha in emulated RGB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

Issue 2535173002: Prevent implicit framebuffer clear from clobbering alpha in emulated RGB (Closed)

Patch Set: remove unnecessary std::list Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/gpu/gpu_tests/pixel_test_pages.py ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

index bf622dc3b37fc80168880842099e99f7c0db8f96..9a17b3a119fe9a79d271ae4d409f94811f76e165 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp

@@ -2576,7 +2576,7 @@ void WebGL2RenderingContextBase::drawArraysInstanced(GLenum mode,

return;

}

- ScopedRGBEmulationColorMask emulationColorMask(contextGL(), m_colorMask,

+ ScopedRGBEmulationColorMask emulationColorMask(this, m_colorMask,

m_drawingBuffer.get());

clearIfComposited();

contextGL()->DrawArraysInstancedANGLE(mode, first, count, instanceCount);

@@ -2597,7 +2597,7 @@ void WebGL2RenderingContextBase::drawElementsInstanced(GLenum mode,

return;

}

- ScopedRGBEmulationColorMask emulationColorMask(contextGL(), m_colorMask,

+ ScopedRGBEmulationColorMask emulationColorMask(this, m_colorMask,

m_drawingBuffer.get());

clearIfComposited();

contextGL()->DrawElementsInstancedANGLE(

@@ -2621,7 +2621,7 @@ void WebGL2RenderingContextBase::drawRangeElements(GLenum mode,

return;

}

- ScopedRGBEmulationColorMask emulationColorMask(contextGL(), m_colorMask,

+ ScopedRGBEmulationColorMask emulationColorMask(this, m_colorMask,

m_drawingBuffer.get());

clearIfComposited();

contextGL()->DrawRangeElements(

@@ -2634,7 +2634,7 @@ void WebGL2RenderingContextBase::drawBuffers(const Vector<GLenum>& buffers) {

if (isContextLost())

return;

- ScopedRGBEmulationColorMask emulationColorMask(contextGL(), m_colorMask,

+ ScopedRGBEmulationColorMask emulationColorMask(this, m_colorMask,

m_drawingBuffer.get());

GLsizei n = buffers.size();

const GLenum* bufs = buffers.data();