third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp - Issue 2535173002: Prevent implicit framebuffer clear from clobbering alpha in emulated RGB

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

Issue 2535173002: Prevent implicit framebuffer clear from clobbering alpha in emulated RGB (Closed)

Patch Set: fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

index a909bea5d88abdf02dd70dd231282cd19247ecc8..1dc1c9839bf290e1f2f86c188c9a0ff824f3f2fd 100644

--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

@@ -987,6 +987,8 @@ void DrawingBuffer::resolveMultisampleFramebufferInternal() {

.disable_multisampling_color_mask_usage) {

m_gl->ClearColor(0, 0, 0, 1);

m_gl->ColorMask(false, false, false, true);

+ m_gl->Clear(GL_COLOR_BUFFER_BIT);

+ m_gl->ColorMask(true, true, true, false);

Ken Russell (switch to Gerrit) 2016/12/01 07:20:43 While I'm pretty sure this was just an omission, t

erikchen 2016/12/01 16:04:11 This was a relatively recent regression from: http

ccameron 2016/12/01 19:25:59 Gah, sorry!!! Shouldn't we be doing m_client->D

Kai Ninomiya 2016/12/01 23:30:20 I see, it looks like the `m_stateRestorer->setClea

}