Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2535143003: More refactoring of enqueuers (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More refactoring of enqueuers - refactor enqueuer/strategy/impact-visitor relations - make helper methods/fields private R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/3af747810f9468d4b7fa808d22b022cf8469d34b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -296 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 24 chunks +128 lines, -167 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 17 chunks +94 lines, -127 lines 2 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/minimal_resolution_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-11-29 10:43:01 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2535143003/diff/1/pkg/compiler/lib/src/js_backend/enqueuer.dart File pkg/compiler/lib/src/js_backend/enqueuer.dart (left): https://codereview.chromium.org/2535143003/diff/1/pkg/compiler/lib/src/js_backend/enqueuer.dart#oldcode251 pkg/compiler/lib/src/js_backend/enqueuer.dart:251: void enableIsolateSupport() {} can we remove all enableIsolateSupport ...
4 years ago (2016-11-29 22:25:03 UTC) #3
Johnni Winther
https://codereview.chromium.org/2535143003/diff/1/pkg/compiler/lib/src/js_backend/enqueuer.dart File pkg/compiler/lib/src/js_backend/enqueuer.dart (left): https://codereview.chromium.org/2535143003/diff/1/pkg/compiler/lib/src/js_backend/enqueuer.dart#oldcode251 pkg/compiler/lib/src/js_backend/enqueuer.dart:251: void enableIsolateSupport() {} On 2016/11/29 22:25:03, Harry Terkelsen wrote: ...
4 years ago (2016-11-30 08:05:23 UTC) #4
Johnni Winther
4 years ago (2016-11-30 08:12:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3af747810f9468d4b7fa808d22b022cf8469d34b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698