Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: src/arm64/lithium-codegen-arm64.cc

Issue 253513003: ARM64: Fix LCodeGen::ToOperand32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/lithium-codegen-arm64.cc
diff --git a/src/arm64/lithium-codegen-arm64.cc b/src/arm64/lithium-codegen-arm64.cc
index 8f5b811820e04e45f1c88a9963a61c2532f94a24..5fb562448bd0d54735543cc880ffd00d80f107c4 100644
--- a/src/arm64/lithium-codegen-arm64.cc
+++ b/src/arm64/lithium-codegen-arm64.cc
@@ -1235,9 +1235,8 @@ Operand LCodeGen::ToOperand32(LOperand* op, IntegerSignedness signedness) {
Representation r = chunk_->LookupLiteralRepresentation(const_op);
if (r.IsInteger32()) {
ASSERT(constant->HasInteger32Value());
- return Operand(signedness == SIGNED_INT32
- ? constant->Integer32Value()
- : static_cast<uint32_t>(constant->Integer32Value()));
+ int64_t value = constant->Integer32Value();
+ return (signedness == SIGNED_INT32) ? value : value & kWRegMask;
ulan 2014/04/25 09:08:18 This will now generate 64-bit RelocInfo. Is this i
jbramley 2014/04/25 13:54:32 Done.
} else {
// Other constants not implemented.
Abort(kToOperand32UnsupportedImmediate);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698