Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 253513003: ARM64: Fix LCodeGen::ToOperand32. (Closed)

Created:
6 years, 8 months ago by jbramley
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM64: Fix LCodeGen::ToOperand32. This fixes the following generated code sequence: movn w1, #0 // Synthesize -1. cmp w0, w1 With a properly-constructed Operand, the MacroAssembler can optimize it as follows: cmn w0, #1 BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20989

Patch Set 1 #

Total comments: 2

Patch Set 2 : Create NONE32 operands. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbramley
6 years, 8 months ago (2014-04-25 08:11:32 UTC) #1
ulan
https://codereview.chromium.org/253513003/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/253513003/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode1239 src/arm64/lithium-codegen-arm64.cc:1239: return (signedness == SIGNED_INT32) ? value : value & ...
6 years, 8 months ago (2014-04-25 09:08:18 UTC) #2
jbramley
On 2014/04/25 09:08:18, ulan wrote: > https://codereview.chromium.org/253513003/diff/1/src/arm64/lithium-codegen-arm64.cc > File src/arm64/lithium-codegen-arm64.cc (right): > > https://codereview.chromium.org/253513003/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode1239 > ...
6 years, 8 months ago (2014-04-25 10:26:24 UTC) #3
jbramley
https://codereview.chromium.org/253513003/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (right): https://codereview.chromium.org/253513003/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode1239 src/arm64/lithium-codegen-arm64.cc:1239: return (signedness == SIGNED_INT32) ? value : value & ...
6 years, 8 months ago (2014-04-25 13:54:32 UTC) #4
ulan
lgtm
6 years, 8 months ago (2014-04-25 14:00:36 UTC) #5
jbramley
6 years, 8 months ago (2014-04-25 14:08:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r20989 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698