disable crtcs bigger than new screen size during mode switch

disable crtcs bigger than new screen size during mode switch

When switching modes, we disable CRTCs that do not fit on current freamebuffer,
change framebuffer size, then enable required CRTCs in the right locations.
This fails in a switch from extended desktop to mirror mode, e.g. from
1366x768+1920x1080 to 1024x768 mirrored. Both CRTCs fit into current framebuffer
but they are smaller than the framebuffer we are about to resize to (1024x768)
so XRRSetScreenSize(1024,768) call fails because it cannot shrink framebuffer
size below size of currently enabled CRTCs. The solution is to disable CRTCs
that are bigger than minimum of current and new framebuffer.

BUG=chromium:366280
TEST=switch between mirror and extended desktop on Link or Squawks. Screen size\
(in DISPLAY=:0.0 xrandr --verbose) should shrink when switching to mirror mode.
R=djkurtz@chromium.org
R=oshima@chromium.org

Signed-off-by: Dominik Behr <dbehr@chromium.org>;

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266095

[oshima, 2014-04-24 21:07:35]

lgtm

[dbehr, 2014-04-24 22:48:08]

The CQ bit was checked by dbehr@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:49:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbehr@chromium.org/253513002/1

[commit-bot: I haz the power, 2014-04-25 02:43:54]

Change committed as 266095

[Daniel Kurtz, 2014-04-25 04:35:29]

lgtm modulo nit

https://codereview.chromium.org/253513002/diff/1/ui/display/chromeos/x11/nati...
File ui/display/chromeos/x11/native_display_delegate_x11.cc (right):

https://codereview.chromium.org/253513002/diff/1/ui/display/chromeos/x11/nati...
ui/display/chromeos/x11/native_display_delegate_x11.cc:558:
DefaultScreen(display_)), new_size.width());
I think this would have been easier to read:
  int current_width = DisplayWidth(display_, DefaultScreen(display_));
  int common_width = std::min(current_width, new_size.width());