Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 25351004: Use translator instead of translator_glsl ANGLE dependency. (Closed)

Created:
7 years, 2 months ago by Zhenyao Mo
Modified:
7 years, 2 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Use translator instead of translator_glsl ANGLE dependency. At the moment legacy translator_glsl is simply a duplication of translator. BUG= TEST=tree Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226903

Patch Set 1 #

Patch Set 2 : add a condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M build/common.gypi View 1 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 2 chunks +9 lines, -1 line 0 comments Download
M gpu/gpu.gyp View 1 4 chunks +18 lines, -2 lines 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Zhenyao Mo
piman: please review.
7 years, 2 months ago (2013-10-03 00:16:12 UTC) #1
piman
LGTM. Make sure to send to trybots, I had tons of issues around there when ...
7 years, 2 months ago (2013-10-03 00:18:37 UTC) #2
Zhenyao Mo
On 2013/10/03 00:18:37, piman wrote: > LGTM. Make sure to send to trybots, I had ...
7 years, 2 months ago (2013-10-03 00:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/25351004/1
7 years, 2 months ago (2013-10-03 14:54:44 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-03 15:27:52 UTC) #5
Zhenyao Mo
James, please take a look at the gyp condition thing you suggested.
7 years, 2 months ago (2013-10-03 21:06:16 UTC) #6
jamesr
Looks good!
7 years, 2 months ago (2013-10-03 21:09:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/25351004/24001
7 years, 2 months ago (2013-10-03 21:12:53 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 00:02:25 UTC) #9
Message was sent while issue was closed.
Change committed as 226903

Powered by Google App Engine
This is Rietveld 408576698