Worker: Connect UseCounter to workers and worklets

Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record API use on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controlled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
Committed: https://crrev.com/258056d1132c92efb77d9f93f26d19b33d438039
Cr-Commit-Position: refs/heads/master@{#436490}

[nhiroki, 2016-11-29 10:56:47]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 10:57:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 11:00:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 11:00:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nhiroki, 2016-11-29 11:12:40]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 11:13:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 12:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 12:32:30]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2016-11-30 02:18:04]

Description was changed from

==========
Worker: Prepare for UseCounter support for workers and worklets other than
DedicatedWorkers

BUG=376039, 667357
==========

to

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation patch for UseCounter support for workers and worklets, and
does not actually enable the use counter on them yet.

BUG=376039, 667357
==========

[nhiroki, 2016-11-30 05:11:53]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 05:12:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 07:11:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 07:11:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nhiroki, 2016-11-30 07:12:50]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 07:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-11-30 08:21:56]

Description was changed from

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation patch for UseCounter support for workers and worklets, and
does not actually enable the use counter on them yet.

BUG=376039, 667357
==========

to

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record usage on them yet.

Call paths that this CL created and what subsequent CL will do are as follows:

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record usage info in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send usage info to the browser process and distribute it to
      connected documents.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send usage info to the browser process and distribute it to
      controlling documents.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record usage info in
    the document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to notify a parent document on the main thread of usage
      info like DedicatedWorkers.

BUG=376039, 667357
==========

[nhiroki, 2016-11-30 08:23:24]

Description was changed from

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record usage on them yet.

Call paths that this CL created and what subsequent CL will do are as follows:

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record usage info in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send usage info to the browser process and distribute it to
      connected documents.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send usage info to the browser process and distribute it to
      controlling documents.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record usage info in
    the document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to notify a parent document on the main thread of usage
      info like DedicatedWorkers.

BUG=376039, 667357
==========

to

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record usage on them yet.

Call paths this CL introduces and what subsequent CL will do are as follows:

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record usage info in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send usage info to the browser process and distribute it to
      connected documents.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send usage info to the browser process and distribute it to
      controlling documents.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record usage info in
    the document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to notify a parent document on the main thread of usage
      info like DedicatedWorkers.

BUG=376039, 667357
==========

[nhiroki, 2016-11-30 08:33:45]

Description was changed from

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record usage on them yet.

Call paths this CL introduces and what subsequent CL will do are as follows:

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record usage info in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send usage info to the browser process and distribute it to
      connected documents.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send usage info to the browser process and distribute it to
      controlling documents.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record usage info in
    the document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to notify a parent document on the main thread of usage
      info like DedicatedWorkers.

BUG=376039, 667357
==========

to

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record usage on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
==========

[nhiroki, 2016-11-30 08:34:19]

Description was changed from

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record usage on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
==========

to

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record API use on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
==========

[nhiroki, 2016-11-30 08:42:59]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-11-30 08:43:07]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2016-11-30 08:44:20]

Description was changed from

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record API use on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
==========

to

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record API use on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controlled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
==========

[nhiroki, 2016-11-30 08:44:21]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2016-11-30 08:45:34]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2016-11-30 08:46:02]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2016-11-30 08:46:11]

Patchset #1 (id:80001) has been deleted

[nhiroki, 2016-11-30 08:46:38]

PTAL, thanks!

[commit-bot: I haz the power, 2016-11-30 09:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 09:07:42]

Dry run: This issue passed the CQ dry run.

[falken, 2016-12-02 08:54:49]

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:31: //
(https://crbug.com/667357)
It's hard to understand the TODO at first but the CL description has a good one.
How about:

// A parent document is on the same thread, so just record API use in the
document's UseCounter.
// TODO(nhiroki): Support UseCounter for main thread worklets.
https://crbug.com/667357
WorkletGlobalScope::countFeature(feature);

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:36:
WorkletGlobalScope::countDeprecation(feature);
ditto

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp:38:
m_thread->workerReportingProxy().countFeature(feature);
Why are both calls needed? This doesn't double count?

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp
(right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp:29: //
(https://crbug.com/376039)
call NOTIMPLEMENTED()?

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp:35: //
(https://crbug.com/376039)
ditto

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:21: // Do
nothing.
Why is this different from countDeprecation? Can you add a comment to explain?

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp (right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:338: //
(https://crbug.com/376039)
NOTIMPLEMENTED?

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp:229: //
(https://crbug.com/376039)
NOTIMPLEMENTED?

[nhiroki, 2016-12-05 04:49:01]

Thank you. Updated.

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:31: //
(https://crbug.com/667357)
On 2016/12/02 08:54:49, falken wrote:
> It's hard to understand the TODO at first but the CL description has a good
one.
> How about:
> 
> // A parent document is on the same thread, so just record API use in the
> document's UseCounter.
> // TODO(nhiroki): Support UseCounter for main thread worklets.
> https://crbug.com/667357
> WorkletGlobalScope::countFeature(feature);

Done.

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp:36:
WorkletGlobalScope::countDeprecation(feature);
On 2016/12/02 08:54:49, falken wrote:
> ditto

Done.

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp:38:
m_thread->workerReportingProxy().countFeature(feature);
On 2016/12/02 08:54:49, falken wrote:
> Why are both calls needed? This doesn't double count?

This doesn't double count because (WorkerOr)WorkletGlobalScope::countFeature()
does nothing.

I meant to call WorkletGlobalScope::countFeature() for putting common operations
in ancestors' countFeature() like countDeprecation(), but it's not necessary for
now. I made it pure-virtual function and removed this call.

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp
(right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp:29: //
(https://crbug.com/376039)
On 2016/12/02 08:54:49, falken wrote:
> call NOTIMPLEMENTED()?

This is reachable and NOTIMPLEMENTED() leads a crash.

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp:35: //
(https://crbug.com/376039)
On 2016/12/02 08:54:49, falken wrote:
> ditto

This is reachable.

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:21: // Do
nothing.
On 2016/12/02 08:54:49, falken wrote:
> Why is this different from countDeprecation? Can you add a comment to explain?

countDeprecation() needs to show a warning message as a common operation among
all workers/worklets. On the other hand, countFeature() doesn't need it.

As other my review reply, I removed this function and made it pure-virtual
instead.

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp (right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:338: //
(https://crbug.com/376039)
On 2016/12/02 08:54:49, falken wrote:
> NOTIMPLEMENTED?

This is reachable.

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/2535093003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp:229: //
(https://crbug.com/376039)
On 2016/12/02 08:54:49, falken wrote:
> NOTIMPLEMENTED?

This is reachable.

[nhiroki, 2016-12-05 06:42:54]

falken@: As an offline chat, I made
WorkerOrWorkletGlobalScope::countDeprecation() pure-virtual and added
addDeprecationMessage() instead. Can you take another look?

[nhiroki, 2016-12-05 06:42:59]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 06:43:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[falken, 2016-12-05 07:07:22]

Do we have a plan for removing the const_cast? Should UseCounter::count just
change now to accept a non-const ExecutionContext?

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:28: //
TODO(nhiroki): Stop using const_cast.
Can the TODO be expanded to explain when this action can be taken?

[nhiroki, 2016-12-05 07:45:38]

Updated.

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:28: //
TODO(nhiroki): Stop using const_cast.
On 2016/12/05 07:07:22, falken wrote:
> Can the TODO be expanded to explain when this action can be taken?

I found we can make countDeprecation() non-const and stop this right now. Done.

Regarding countFeature(), it'd be tough to make it non-const because
UseCounter::count(), a caller of countFeature(), is called with 'this' (i.e,
const ExecutionContext*) in many places. So, I'd like to leave it as is.

[nhiroki, 2016-12-05 07:45:42]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 07:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[falken, 2016-12-05 07:54:34]

lgtm, thanks

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:28: //
TODO(nhiroki): Stop using const_cast.
On 2016/12/05 07:45:38, nhiroki wrote:
> On 2016/12/05 07:07:22, falken wrote:
> > Can the TODO be expanded to explain when this action can be taken?
> 
> I found we can make countDeprecation() non-const and stop this right now.
Done.
> 
> Regarding countFeature(), it'd be tough to make it non-const because
> UseCounter::count(), a caller of countFeature(), is called with 'this' (i.e,
> const ExecutionContext*) in many places. So, I'd like to leave it as is.

Nice. I thought I could remove countFeature()'s const pretty simply, only one or
two callsites needed updating. But as long as the const_cast is gone I think
we're in good shape with this patch.

[nhiroki, 2016-12-05 08:13:31]

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:28: //
TODO(nhiroki): Stop using const_cast.
On 2016/12/05 07:54:34, falken wrote:
> On 2016/12/05 07:45:38, nhiroki wrote:
> > On 2016/12/05 07:07:22, falken wrote:
> > > Can the TODO be expanded to explain when this action can be taken?
> > 
> > I found we can make countDeprecation() non-const and stop this right now.
> Done.
> > 
> > Regarding countFeature(), it'd be tough to make it non-const because
> > UseCounter::count(), a caller of countFeature(), is called with 'this' (i.e,
> > const ExecutionContext*) in many places. So, I'd like to leave it as is.
> 
> Nice. I thought I could remove countFeature()'s const pretty simply, only one
or
> two callsites needed updating. But as long as the const_cast is gone I think
> we're in good shape with this patch.

Oh... obviously I misunderstood something. I just tried to remove 'const'
qualifier from UseCounter::cound() and it succeeded with very simple changes.
I'll include them in this CL...

[nhiroki, 2016-12-05 08:21:46]

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/200001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:28: //
TODO(nhiroki): Stop using const_cast.
On 2016/12/05 08:13:30, nhiroki wrote:
> On 2016/12/05 07:54:34, falken wrote:
> > On 2016/12/05 07:45:38, nhiroki wrote:
> > > On 2016/12/05 07:07:22, falken wrote:
> > > > Can the TODO be expanded to explain when this action can be taken?
> > > 
> > > I found we can make countDeprecation() non-const and stop this right now.
> > Done.
> > > 
> > > Regarding countFeature(), it'd be tough to make it non-const because
> > > UseCounter::count(), a caller of countFeature(), is called with 'this'
(i.e,
> > > const ExecutionContext*) in many places. So, I'd like to leave it as is.
> > 
> > Nice. I thought I could remove countFeature()'s const pretty simply, only
one
> or
> > two callsites needed updating. But as long as the const_cast is gone I think
> > we're in good shape with this patch.
> 
> Oh... obviously I misunderstood something. I just tried to remove 'const'
> qualifier from UseCounter::cound() and it succeeded with very simple changes.
> I'll include them in this CL...

Updated :)

[nhiroki, 2016-12-05 08:22:45]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 08:22:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[falken, 2016-12-05 08:24:00]

still lgtm

[nhiroki, 2016-12-05 08:24:36]

nhiroki@chromium.org changed reviewers:
+ haraken@chromium.org

[nhiroki, 2016-12-05 08:24:37]

+haraken@, can you review changes under core/ and web/? Thanks.

[commit-bot: I haz the power, 2016-12-05 10:46:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 10:46:48]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-12-05 11:37:28]

https://codereview.chromium.org/2535093003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:32:
Deprecation::deprecationMessage(feature)));

Instead of maintaining m_deprecationWarningBits per worker, can we just send
UseCounter::Feature to the main thread and use the existing UseCounter's
BitVector to prevent the message duplication?

[nhiroki, 2016-12-06 02:22:04]

Thank you. Comment reply only.

https://codereview.chromium.org/2535093003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:32:
Deprecation::deprecationMessage(feature)));
On 2016/12/05 11:37:27, haraken wrote:
> 
> Instead of maintaining m_deprecationWarningBits per worker, can we just send
> UseCounter::Feature to the main thread and use the existing UseCounter's
> BitVector to prevent the message duplication?

I'd prefer to keep this as is because:
(1) DeprecationMessage will be printed in worker's console from worker thread,
so thread-hopping to check the existing UseCounter's BitVector could be
inefficient.
(2) Out-of-process workers (e.g., ServiceWorker) will involve inter-process
communications to count API use in Document's UseCounter and the way wouldn't be
practical.

[haraken, 2016-12-06 02:28:55]

LGTM

https://codereview.chromium.org/2535093003/diff/240001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp
(right):

https://codereview.chromium.org/2535093003/diff/240001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/workers/WorkerOrWorkletGlobalScope.cpp:32:
Deprecation::deprecationMessage(feature)));
On 2016/12/06 02:22:04, nhiroki wrote:
> On 2016/12/05 11:37:27, haraken wrote:
> > 
> > Instead of maintaining m_deprecationWarningBits per worker, can we just send
> > UseCounter::Feature to the main thread and use the existing UseCounter's
> > BitVector to prevent the message duplication?
> 
> I'd prefer to keep this as is because:
> (1) DeprecationMessage will be printed in worker's console from worker thread,
> so thread-hopping to check the existing UseCounter's BitVector could be
> inefficient.
> (2) Out-of-process workers (e.g., ServiceWorker) will involve inter-process
> communications to count API use in Document's UseCounter and the way wouldn't
be
> practical.

Ah, makes sense. I was misunderstanding that the deprecation message is printed
on main thread's console.

[nhiroki, 2016-12-06 02:30:07]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:30:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 02:38:11]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1480991407219810,
"parent_rev": "3603c024f4e1a6aceef7cd169acf82199876badb", "commit_rev":
"11ca12d9f4533ee76d7a47a4edd24fa2d29c66eb"}

[commit-bot: I haz the power, 2016-12-06 02:38:59]

Description was changed from

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record API use on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controlled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
==========

to

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record API use on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controlled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
==========

[commit-bot: I haz the power, 2016-12-06 02:39:01]

Committed patchset #8 (id:240001)

[commit-bot: I haz the power, 2016-12-06 02:42:46]

Description was changed from

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record API use on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controlled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357
==========

to

==========
Worker: Connect UseCounter to workers and worklets

This is a preparation CL for UseCounter support on workers and worklets, and
does not actually record API use on them yet.

This CL introduces new interfaces WorkerOrWorkletGlobalScope::countFeature() and
WorkerReportingProxy::countFeature() so that UseCounter can transparently report
API use to workers and worklets. After this change, call paths are as follows
(TODO comments will be addressed by subsequent CLs):

For DedicatedWorkers (Note: UseCounter is already enabled on DedicatedWorkers)
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - InProcessWorkerObjectProxy::countFeature()
      - (Worker Thread -> Main Thread)
      - ThreadedMessagingProxyBase::countFeature()
      - Record API use in a parent document's UseCounter.

For SharedWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - WebSharedWorkerImpl::countFeature()
    - TODO: Send an IPC message to the browser process and ask each connected
      document to record API use in its UseCounter.

For ServiceWorkers
- UseCounter::countFeature()
  - WorkerGlobalScope::countFeature()
    - ServiceWorkerGlobalScopeProxy::countFeature()
    - TODO: Send an IPC message to the browser process and ask each controlled
      document to record API use in its UseCounter.

For MainThreadWorklets
- UseCounter::countFeature()
  - MainThreadWorkletGlobalScope::countFeature()
  - TODO: A parent document is on the same thread, so just record API use in the
    document's UseCounter.

For ThreadedWorklets
- UseCounter::countFeature()
  - ThreadedWorkletGlobalScope::countFeature()
    - ThreadedWorkletObjectProxy::countFeature()
    - TODO: Post a task to report API use to a parent document on the main
      thread like DedicatedWorkers.

BUG=376039, 667357

Committed: https://crrev.com/258056d1132c92efb77d9f93f26d19b33d438039
Cr-Commit-Position: refs/heads/master@{#436490}
==========

[commit-bot: I haz the power, 2016-12-06 02:42:48]

Patchset 8 (id:??) landed as
https://crrev.com/258056d1132c92efb77d9f93f26d19b33d438039
Cr-Commit-Position: refs/heads/master@{#436490}