Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2535063002: [M56] Consolidate how ImageDocument sets image styling (Closed)

Created:
4 years ago by gone
Modified:
4 years ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[M56] Consolidate how ImageDocument sets image styling * Consolidate how the image sets the cursor styling inside of updateImageStyle(), which now checks for whether the cursor or checkerboard size has changed during styling updates. * Fix how the magnifying glass cursor is initialized on desktop versions of the page. BUG=664782 TBR=pdr@chromium.org Original-Review-Url: https://codereview.chromium.org/2523553002 Original-Cr-Commit-Position: refs/heads/master@{#434020} Committed: https://chromium.googlesource.com/chromium/src/+/c45131ad8acfc30cf22e7113a8029d26f7ec4bb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 7 chunks +31 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
gone
4 years ago (2016-11-28 21:08:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c45131ad8acfc30cf22e7113a8029d26f7ec4bb8.

Powered by Google App Engine
This is Rietveld 408576698