Time box _FilesReferencingNameTask.

Time box _FilesReferencingNameTask.

Relinquishing execution flow and running event loop after every piece
of work in _FilesReferencingNameTask works, but has too much overhead.
If we instead use a fixed time quantum, we can spend less time overall.

E.g. time to search in analyzer files is 400 microseconds.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/564be5bc3b80381f5d1042dc8c933df9f23d15a7

[Paul Berry, 2016-11-28 20:17:41]

lgtm

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1259: * Perform work for `10 ms`,
and either complete the [completer] and
This says "10 ms" but the code below seems to allow 5 ms.  Suggestion: change
the comment to say "a fixed length of time" instead of naming a specific
interval.

[scheglov, 2016-11-28 20:20:17]

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1259: * Perform work for `10 ms`,
and either complete the [completer] and
On 2016/11/28 20:17:40, Paul Berry wrote:
> This says "10 ms" but the code below seems to allow 5 ms.  Suggestion: change
> the comment to say "a fixed length of time" instead of naming a specific
> interval.

Ah, good idea.
Done.

[Brian Wilkerson, 2016-11-28 20:45:04]

lgtm

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1265: while
(timer.elapsedMilliseconds < 5) {
Please add a comment describing the tradeoffs you outlined in the CL's comment,
so that we remember the implications of tweaking this value (and explaining why
it was chosen).

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1273: if (filesToCheck.isEmpty) {
Do we need to perform these two checks on every iteration, or could these be
moved outside the while-loop, allowing us to get more work done in the 5 ms?

[scheglov, 2016-11-28 21:19:27]

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1265: while
(timer.elapsedMilliseconds < 5) {
On 2016/11/28 20:45:04, Brian Wilkerson wrote:
> Please add a comment describing the tradeoffs you outlined in the CL's
comment,
> so that we remember the implications of tweaking this value (and explaining
why
> it was chosen).

Done.

https://codereview.chromium.org/2535053002/diff/20001/pkg/analyzer/lib/src/da...
pkg/analyzer/lib/src/dart/analysis/driver.dart:1273: if (filesToCheck.isEmpty) {
On 2016/11/28 20:45:04, Brian Wilkerson wrote:
> Do we need to perform these two checks on every iteration, or could these be
> moved outside the while-loop, allowing us to get more work done in the 5 ms?

These checks are cheap.

[scheglov, 2016-11-28 21:22:08]

Description was changed from

==========
Time box _FilesReferencingNameTask.

Relinquishing execution flow and running event loop after every piece
of work in _FilesReferencingNameTask works, but has too much overhead.
If we instead use a fixed time quantum, we can spend less time overall.

E.g. time to search in analyzer files is 400 microseconds.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Time box _FilesReferencingNameTask.

Relinquishing execution flow and running event loop after every piece
of work in _FilesReferencingNameTask works, but has too much overhead.
If we instead use a fixed time quantum, we can spend less time overall.

E.g. time to search in analyzer files is 400 microseconds.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/564be5bc3b80381f5d1042dc8c933df9f23d15a7
==========

[scheglov, 2016-11-28 21:22:10]

Committed patchset #2 (id:20001) manually as
564be5bc3b80381f5d1042dc8c933df9f23d15a7 (presubmit successful).