Fix MediaDevices* tests dependency on BrowserThread globals after ~BrowserThreadImpl().

content/browser/renderer_host/media/media_devices_manager_unittest.cc

Index: content/browser/renderer_host/media/media_devices_manager_unittest.cc
diff --git a/content/browser/renderer_host/media/media_devices_manager_unittest.cc b/content/browser/renderer_host/media/media_devices_manager_unittest.cc
index cdbac6481a7c736508aef10fa09428902b7fd0a1..6f705d6db8a3b650c0609855a2f838f271e99c59 100644
--- a/content/browser/renderer_host/media/media_devices_manager_unittest.cc
+++ b/content/browser/renderer_host/media/media_devices_manager_unittest.cc
@@ -125,8 +125,8 @@ class MockMediaDeviceChangeSubscriber : public MediaDeviceChangeSubscriber {
 class MediaDevicesManagerTest : public ::testing::Test {
  public:
   MediaDevicesManagerTest()
-      : video_capture_device_factory_(nullptr),
-        thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {}
+      : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
+        video_capture_device_factory_(nullptr) {}
   ~MediaDevicesManagerTest() override {}
 
   MOCK_METHOD1(MockCallback, void(const MediaDeviceEnumeration&));
@@ -156,10 +156,11 @@ class MediaDevicesManagerTest : public ::testing::Test {
         type, MediaDevicesManager::CachePolicy::SYSTEM_MONITOR);
   }
 
+  TestBrowserThreadBundle thread_bundle_;

[liberato (no reviews please), 2016/11/29 16:46:52]

it's worth a comment here that destruction order is important, and what depends
on it.

[gab, 2016/11/29 18:24:50]

Done.

+
   std::unique_ptr<MediaDevicesManager> media_devices_manager_;
   scoped_refptr<VideoCaptureManager> video_capture_manager_;
   MockVideoCaptureDeviceFactory* video_capture_device_factory_;
-  TestBrowserThreadBundle thread_bundle_;
   std::unique_ptr<MockAudioManager, media::AudioManagerDeleter> audio_manager_;
 
  private: