Fix MediaDevices* tests dependency on BrowserThread globals after ~BrowserThreadImpl().

Fix MediaDevices* tests dependency on BrowserThread globals after ~BrowserThreadImpl().

Mostly a matter of tweaking destruction order in test and adding an
additional flush instead of depending on ~MediaStreamManager() implicitly
flushing MediaStreamManager::video_capture_thread_().

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after that
fact.

BUG=653916
Committed: https://crrev.com/e65b9d238a74d05a7b496d2cee9e4bcbde7623ad
Cr-Commit-Position: refs/heads/master@{#435055}

[gab, 2016-11-28 21:59:49]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 22:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-11-28 22:01:04]

gab@chromium.org changed reviewers:
+ liberato@chromium.org

[gab, 2016-11-28 22:01:05]

liberato@ PTAL, thanks!

[commit-bot: I haz the power, 2016-11-29 00:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 00:18:13]

Dry run: This issue passed the CQ dry run.

[liberato (no reviews please), 2016-11-29 16:46:52]

sorry for the delay.  got distracted and forgot to send it.

thanks
-fl

https://codereview.chromium.org/2535043003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/media_devices_manager_unittest.cc
(right):

https://codereview.chromium.org/2535043003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/media_devices_manager_unittest.cc:159:
TestBrowserThreadBundle thread_bundle_;
it's worth a comment here that destruction order is important, and what depends
on it.

[gab, 2016-11-29 18:24:51]

Done PTAnL

https://codereview.chromium.org/2535043003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/media/media_devices_manager_unittest.cc
(right):

https://codereview.chromium.org/2535043003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/media/media_devices_manager_unittest.cc:159:
TestBrowserThreadBundle thread_bundle_;
On 2016/11/29 16:46:52, liberato wrote:
> it's worth a comment here that destruction order is important, and what
depends
> on it.

Done.

[gab, 2016-11-29 18:24:56]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 18:25:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[liberato (no reviews please), 2016-11-29 18:38:37]

lgtm

[gab, 2016-11-29 19:36:23]

The CQ bit was unchecked by gab@chromium.org

[gab, 2016-11-29 19:36:27]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-11-29 19:37:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 19:46:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480448187580970,
"parent_rev": "2ea9d62432412788c7e67c2884f13433dbe169a6", "commit_rev":
"fe2acb0632bf8a090f57e78b81ad34ce4cb0fbd4"}

[commit-bot: I haz the power, 2016-11-29 19:47:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 19:50:21]

Description was changed from

==========
Fix MediaDevices* tests dependency on BrowserThread globals after
~BrowserThreadImpl().

Mostly a matter of tweaking destruction order in test and adding an
additional flush instead of depending on ~MediaStreamManager() implicitly
flushing MediaStreamManager::video_capture_thread_().

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after that
fact.

BUG=653916
==========

to

==========
Fix MediaDevices* tests dependency on BrowserThread globals after
~BrowserThreadImpl().

Mostly a matter of tweaking destruction order in test and adding an
additional flush instead of depending on ~MediaStreamManager() implicitly
flushing MediaStreamManager::video_capture_thread_().

This is a prereq to https://codereview.chromium.org/2464233002 which
will from now on reset BrowserThread globals associated with destroyed
BrowserThreadImpls and thus makes DCHECK_CURRENTLY_ON fail after that
fact.

BUG=653916

Committed: https://crrev.com/e65b9d238a74d05a7b496d2cee9e4bcbde7623ad
Cr-Commit-Position: refs/heads/master@{#435055}
==========

[commit-bot: I haz the power, 2016-11-29 19:50:22]

Patchset 2 (id:??) landed as
https://crrev.com/e65b9d238a74d05a7b496d2cee9e4bcbde7623ad
Cr-Commit-Position: refs/heads/master@{#435055}