chrome/browser/android/offline_pages/offline_page_utils.cc - Issue 2535023002: [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils.cc

Issue 2535023002: [Offline pages] Fixing OfflinePageUtis::EqualsIgnoringFragment (Closed)

Patch Set: Fixing a previews test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/offline_pages/offline_page_utils.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils.cc b/chrome/browser/android/offline_pages/offline_page_utils.cc

index 4c3dc300d9b3873a7ba1f81958b4eca376624dee..63b321f009c01366a3422ad73189bc397d60333f 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils.cc

@@ -213,7 +213,7 @@ bool OfflinePageUtils::EqualsIgnoringFragment(const GURL& lhs,

remove_params.ClearRef();

GURL lhs_stripped = lhs.ReplaceComponents(remove_params);

- GURL rhs_stripped = lhs.ReplaceComponents(remove_params);

+ GURL rhs_stripped = rhs.ReplaceComponents(remove_params);

return lhs_stripped == rhs_stripped;

}