Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2535013002: Add an override to SpdyFramerVisitorAdapter. (Closed)

Created:
4 years ago by diannahu
Modified:
4 years ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an override to SpdyFramerVisitorAdapter. This CL lands server change 139914335 by diannahu. BUG=488484 Committed: https://crrev.com/b61fbcaacb7bd9e0bc85c6c061308b62986b7b46 Cr-Commit-Position: refs/heads/master@{#434992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/spdy/spdy_framer_decoder_adapter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer_decoder_adapter.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
diannahu
Thanks!
4 years ago (2016-11-29 03:59:43 UTC) #10
Bence
LGTM.
4 years ago (2016-11-29 13:13:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535013002/1
4 years ago (2016-11-29 15:13:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 15:17:32 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-29 15:20:50 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b61fbcaacb7bd9e0bc85c6c061308b62986b7b46
Cr-Commit-Position: refs/heads/master@{#434992}

Powered by Google App Engine
This is Rietveld 408576698