Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc

Issue 2534983002: Re-enabled UserCloudPolicyManagerChromeOS unit tests (Closed)
Patch Set: review feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
index df022e079ba55af148393bb888d37c1922c71e2e..375a2722ad5e747b00f884b0c7db4a3d626c9ae9 100644
--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
@@ -118,6 +118,14 @@ UserCloudPolicyManagerChromeOS::UserCloudPolicyManagerChromeOS(
}
}
+void UserCloudPolicyManagerChromeOS::ForceTimeoutForTest() {
+ DCHECK(policy_fetch_timeout_.IsRunning());
+ // Stop the timer to mimic what happens when a real timer fires, then invoke
+ // the timer callback directly.
+ policy_fetch_timeout_.Stop();
+ OnBlockingFetchTimeout();
+}
+
UserCloudPolicyManagerChromeOS::~UserCloudPolicyManagerChromeOS() {}
void UserCloudPolicyManagerChromeOS::Connect(
@@ -303,6 +311,7 @@ void UserCloudPolicyManagerChromeOS::OnStoreLoaded(
em::PolicyData const* const policy_data = cloud_policy_store->policy();
if (policy_data) {
+ DCHECK(policy_data->has_username());
chromeos::AffiliationIDSet set_of_user_affiliation_ids(
policy_data->user_affiliation_ids().begin(),
policy_data->user_affiliation_ids().end());

Powered by Google App Engine
This is Rietveld 408576698