Re-enabled UserCloudPolicyManagerChromeOS unit tests

chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h"
 
 #include <set>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 100 matching lines @@
       !initial_policy_fetch_timeout.is_max();
   if (wait_for_policy_fetch_ && allow_failed_policy_fetches_) {
     policy_fetch_timeout_.Start(
         FROM_HERE,
         initial_policy_fetch_timeout,
         base::Bind(&UserCloudPolicyManagerChromeOS::OnBlockingFetchTimeout,
                    base::Unretained(this)));
   }
 }
 
+void UserCloudPolicyManagerChromeOS::ForceTimeoutForTest() {
+  DCHECK(policy_fetch_timeout_.IsRunning());
+  policy_fetch_timeout_.Stop();

[pmarko, 2016/11/29 14:03:34]

nit: I think stopping the timer would not be strictly necessary because
OnBlockingFetchTimeout has to stop the timer anyway.

[Andrew T Wilson (Slow), 2016/11/30 10:02:34]

Agreed, but I'm trying to mimic the behavior of a real timer firing (so the
timer would have been stopped by the time the timeout callback was invoked).
I've added a comment.

+  this->OnBlockingFetchTimeout();

[emaxx, 2016/11/29 16:21:15]

nit: Is "this->" really needed here?

[Andrew T Wilson (Slow), 2016/11/30 10:02:34]

No, you are just seeing the artifacts of a rusty manager trying to write code.

+}
+
 UserCloudPolicyManagerChromeOS::~UserCloudPolicyManagerChromeOS() {}
 
 void UserCloudPolicyManagerChromeOS::Connect(
     PrefService* local_state,
     DeviceManagementService* device_management_service,
     scoped_refptr<net::URLRequestContextGetter> system_request_context) {
   DCHECK(device_management_service);
   DCHECK(local_state);
   local_state_ = local_state;
   // Note: |system_request_context| can be null for tests.
@@ skipping 165 matching lines @@
   StartRefreshSchedulerIfReady();
 }
 
 void UserCloudPolicyManagerChromeOS::OnStoreLoaded(
     CloudPolicyStore* cloud_policy_store) {
   CloudPolicyManager::OnStoreLoaded(cloud_policy_store);
 
   em::PolicyData const* const policy_data = cloud_policy_store->policy();
 
   if (policy_data) {
+    DCHECK(policy_data->has_username());
     chromeos::AffiliationIDSet set_of_user_affiliation_ids(
         policy_data->user_affiliation_ids().begin(),
         policy_data->user_affiliation_ids().end());
 
     chromeos::ChromeUserManager::Get()->SetUserAffiliation(
         policy_data->username(), set_of_user_affiliation_ids);
   }
 }
 
 void UserCloudPolicyManagerChromeOS::GetChromePolicy(PolicyMap* policy_map) {
@@ skipping 132 matching lines @@
     // OnComponentCloudPolicyUpdated() once it's ready.
     return;
   }
 
   core()->StartRefreshScheduler();
   core()->TrackRefreshDelayPref(local_state_,
                                 policy_prefs::kUserPolicyRefreshRate);
 }
 
 }  // namespace policy