Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3339)

Unified Diff: ash/shelf/shelf_view_unittest.cc

Issue 2534953006: Fix shelf auto-hide calculation for app-list visibility. (Closed)
Patch Set: Cleanup. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_view_unittest.cc
diff --git a/ash/shelf/shelf_view_unittest.cc b/ash/shelf/shelf_view_unittest.cc
index 3f4fc968204e08da3aa5edddc3df2e5023343ecf..22fbe20a3ffec5d7fe88c0a74d1e8410b8a4f83f 100644
--- a/ash/shelf/shelf_view_unittest.cc
+++ b/ash/shelf/shelf_view_unittest.cc
@@ -2044,6 +2044,7 @@ class ListMenuShelfItemDelegate : public TestShelfItemDelegate {
// simulating end of the animation. Similar to the actual AppListPresenter, this
// class toggles app list visibility based on the actual visibility rather than
// the target visibility (which might be different due to in-flight animation).
+// This test class doesn't support checking for display-specific visibility.
class TestAppListPresenter : public app_list::AppListPresenter {
public:
TestAppListPresenter() {}
@@ -2060,8 +2061,14 @@ class TestAppListPresenter : public app_list::AppListPresenter {
else
Show(display_id);
}
- bool IsVisible() const override { return is_visible_; }
- bool GetTargetVisibility() const override { return target_visibility_; }
+ bool IsVisible(
+ int64_t display_id = display::kInvalidDisplayId) const override {
+ return is_visible_;
+ }
+ bool GetTargetVisibility(
+ int64_t display_id = display::kInvalidDisplayId) const override {
+ return target_visibility_;
+ }
private:
bool is_visible_ = false;

Powered by Google App Engine
This is Rietveld 408576698