xfa/fxbarcode/oned/BC_OneDimWriter.cpp - Issue 2534953004: Return unique_ptrs from CFX_DIBitmap::Clone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxbarcode/oned/BC_OneDimWriter.cpp

Issue 2534953004: Return unique_ptrs from CFX_DIBitmap::Clone(). (Closed)

Patch Set: nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxbarcode/oned/BC_OneDimWriter.cpp

diff --git a/xfa/fxbarcode/oned/BC_OneDimWriter.cpp b/xfa/fxbarcode/oned/BC_OneDimWriter.cpp

index 0555ba65fd4a9e7adb885126ad2b44b1ee77423b..09f7aea9dbf24a1f082381d87eef1ed6e757cc17 100644

--- a/xfa/fxbarcode/oned/BC_OneDimWriter.cpp

+++ b/xfa/fxbarcode/oned/BC_OneDimWriter.cpp

@@ -343,9 +343,10 @@ void CBC_OneDimWriter::RenderBitmapResult(CFX_DIBitmap*& pOutBitmap,

e);

BC_EXCEPTION_CHECK_ReturnVoid(e);

}

- CFX_DIBitmap* pStretchBitmap = pOutBitmap->StretchTo(m_Width, m_Height);

+ std::unique_ptr<CFX_DIBitmap> pStretchBitmap =

+ pOutBitmap->StretchTo(m_Width, m_Height);

delete pOutBitmap;

- pOutBitmap = pStretchBitmap;

+ pOutBitmap = pStretchBitmap.release();

}

void CBC_OneDimWriter::RenderDeviceResult(CFX_RenderDevice* device,

« no previous file with comments | « xfa/fxbarcode/BC_TwoDimWriter.cpp ('k') | xfa/fxfa/app/xfa_ffwidget.cpp » ('j') | no next file with comments »