core/fpdfapi/render/render_int.h - Issue 2534953004: Return unique_ptrs from CFX_DIBitmap::Clone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/render/render_int.h

Issue 2534953004: Return unique_ptrs from CFX_DIBitmap::Clone(). (Closed)

Patch Set: nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/render/render_int.h

diff --git a/core/fpdfapi/render/render_int.h b/core/fpdfapi/render/render_int.h

index 5d04fa77bb6ebb2c6c97b128f978470e71b299ca..276370d386b43293d5d1751be7e42587d45a1ba7 100644

--- a/core/fpdfapi/render/render_int.h

+++ b/core/fpdfapi/render/render_int.h

@@ -85,8 +85,6 @@ class CPDF_DIBSource : public CFX_DIBSource {

int clip_left,

int clip_width) const override;

- CFX_DIBitmap* GetBitmap() const;

- void ReleaseBitmap(CFX_DIBitmap* pBitmap) const;

uint32_t GetMatteColor() const { return m_MatteColor; }

int StartLoadDIBSource(CPDF_Document* pDoc,