core/fpdfapi/font/cpdf_type3char.cpp - Issue 2534953004: Return unique_ptrs from CFX_DIBitmap::Clone().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/font/cpdf_type3char.cpp

Issue 2534953004: Return unique_ptrs from CFX_DIBitmap::Clone(). (Closed)

Patch Set: typo Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/font/cpdf_type3char.cpp

diff --git a/core/fpdfapi/font/cpdf_type3char.cpp b/core/fpdfapi/font/cpdf_type3char.cpp

index e5b7450a0a30eb2d87be999cc88c68b69ad68e6c..41ab82471753fed0c69466db9ba21e642ebb01eb 100644

--- a/core/fpdfapi/font/cpdf_type3char.cpp

+++ b/core/fpdfapi/font/cpdf_type3char.cpp

@@ -32,7 +32,7 @@ bool CPDF_Type3Char::LoadBitmap(CPDF_RenderContext* pContext) {

std::unique_ptr<CFX_DIBSource> pSource(

pPageObj->AsImage()->GetImage()->LoadDIBSource());

if (pSource)

- m_pBitmap.reset(pSource->Clone());

+ m_pBitmap = pSource->Clone();

m_pForm.reset();

return true;

}