Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fxbarcode/oned/BC_OneDimWriter.cpp

Issue 2534953004: Return unique_ptrs from CFX_DIBitmap::Clone(). (Closed)
Patch Set: win again Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/fxbarcode/BC_TwoDimWriter.cpp ('K') | « xfa/fxbarcode/BC_TwoDimWriter.cpp ('k') | xfa/fxfa/app/xfa_ffwidget.cpp » ('j') | xfa/fxfa/app/xfa_ffwidget.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxbarcode/oned/BC_OneDimWriter.cpp
diff --git a/xfa/fxbarcode/oned/BC_OneDimWriter.cpp b/xfa/fxbarcode/oned/BC_OneDimWriter.cpp
index 0555ba65fd4a9e7adb885126ad2b44b1ee77423b..09f7aea9dbf24a1f082381d87eef1ed6e757cc17 100644
--- a/xfa/fxbarcode/oned/BC_OneDimWriter.cpp
+++ b/xfa/fxbarcode/oned/BC_OneDimWriter.cpp
@@ -343,9 +343,10 @@ void CBC_OneDimWriter::RenderBitmapResult(CFX_DIBitmap*& pOutBitmap,
e);
BC_EXCEPTION_CHECK_ReturnVoid(e);
}
- CFX_DIBitmap* pStretchBitmap = pOutBitmap->StretchTo(m_Width, m_Height);
+ std::unique_ptr<CFX_DIBitmap> pStretchBitmap =
+ pOutBitmap->StretchTo(m_Width, m_Height);
delete pOutBitmap;
- pOutBitmap = pStretchBitmap;
+ pOutBitmap = pStretchBitmap.release();
dsinclair 2016/12/05 20:41:26 ditto
Tom Sepez 2016/12/05 21:38:13 ditto
}
void CBC_OneDimWriter::RenderDeviceResult(CFX_RenderDevice* device,
« xfa/fxbarcode/BC_TwoDimWriter.cpp ('K') | « xfa/fxbarcode/BC_TwoDimWriter.cpp ('k') | xfa/fxfa/app/xfa_ffwidget.cpp » ('j') | xfa/fxfa/app/xfa_ffwidget.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698