Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 253493009: Roll gyp r1895:1907 (Closed)

Created:
6 years, 7 months ago by Torne
Modified:
6 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, rkc
Visibility:
Public.

Description

Roll gyp r1895:1907 r1907 Test handling of empty RULE_INPUT_DIRNAME and fix this on android. r1906 gyp performance: Another fixed O(n^2) in dependency calcs. r1905 gyp: isinstance -> type for another 1-5% save. r1904 gyp: avoid copying items that will be deleted. r1903 Show ASM output file instead of input file, just like CC and CXX. r1902 win: disable two flaky tests on gyp-win32 r1901 Remove the default setting for clcompile_cmd in msvs-ninja r1900 gyp: cache conditional ASTs for 3 CPU seconds (5%) gain. r1899 gyp: use a set() in DeepDependencies for less O(n^2). r1898 gyp: fix O(n^2) in dependency calculations. r1897 gyp: 1% faster by optimizing IsPathSections r1896 gyp: use all processors instead of hard-coded 8. TBR=thakis@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Torne
6 years, 7 months ago (2014-04-28 09:39:43 UTC) #1
Torne
The CQ bit was checked by torne@chromium.org
6 years, 7 months ago (2014-04-28 09:39:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/253493009/1
6 years, 7 months ago (2014-04-28 09:40:14 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 11:07:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 11:07:42 UTC) #5
Torne
No idea how this cl can be making IndexedDBBrowserTestSingleProcess.RenderThreadShutdownTest fail on chromeos, but it's done ...
6 years, 7 months ago (2014-04-28 13:03:37 UTC) #6
Torne
The CQ bit was checked by torne@chromium.org
6 years, 7 months ago (2014-04-28 15:38:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/253493009/1
6 years, 7 months ago (2014-04-28 15:38:12 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 15:39:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_dbg_triggered_tests
6 years, 7 months ago (2014-04-28 15:39:45 UTC) #10
Torne
The CQ bit was checked by torne@chromium.org
6 years, 7 months ago (2014-04-29 12:22:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/253493009/1
6 years, 7 months ago (2014-04-29 12:22:59 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 12:26:19 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 12:26:20 UTC) #14
Torne
Committed patchset #1 manually as r266876 (presubmit successful).
6 years, 7 months ago (2014-04-29 14:24:42 UTC) #15
Torne
6 years, 7 months ago (2014-04-29 14:25:47 UTC) #16
Message was sent while issue was closed.
Will roll this out if there's actually a problem with it since the trybots seem
to be being unreliable :/

Powered by Google App Engine
This is Rietveld 408576698