Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 253493007: Fix to build sdch target under clang. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix to build sdch target under clang and gcc 4.8 when in c++11 mode. This ports the gyp's changes from r258918 ( https://codereview.chromium.org/205963004/) To test: $ gn gen out/Release_gn --args='is_debug=false is_clang=true' $ ninja -C out/Release_gn sdch BUG=367597, 324299 TEST=see above R=brettw@chromium.org TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/gn/secondary/sdch/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
6 years, 8 months ago (2014-04-28 03:20:53 UTC) #1
Nico
(From the Cl description of the Cl you're linking to: "This is also needed for ...
6 years, 8 months ago (2014-04-28 03:24:54 UTC) #2
tfarina
On 2014/04/28 03:24:54, Nico wrote: > (From the Cl description of the Cl you're linking ...
6 years, 8 months ago (2014-04-28 04:41:37 UTC) #3
Mostyn Bramley-Moore
Non-owner lgtm. Tested with gcc 4.8.1 and it seems to work, however I need to ...
6 years, 8 months ago (2014-04-28 08:39:43 UTC) #4
tfarina
Brett, I'm committing this. Feel free to yell at me if you want me to ...
6 years, 7 months ago (2014-04-30 01:44:44 UTC) #5
tfarina
6 years, 7 months ago (2014-04-30 01:49:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r267039 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698