Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: components/reading_list/ios/proto/reading_list.proto

Issue 2534903003: Reading list: add first read PB entries (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync/protocol/reading_list_specifics.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/reading_list/ios/proto/reading_list.proto
diff --git a/components/reading_list/ios/proto/reading_list.proto b/components/reading_list/ios/proto/reading_list.proto
index e1346e4304ecc8bb364d78cebce00e05182b9b88..2b976910131e09229e81233efc3919a2d7a28fd7 100644
--- a/components/reading_list/ios/proto/reading_list.proto
+++ b/components/reading_list/ios/proto/reading_list.proto
@@ -15,14 +15,11 @@ package reading_list;
// sync_pb.ReadingListSpecifics protobuf.
message ReadingListLocal {
optional string entry_id = 1;
-
optional string title = 2;
-
optional string url = 3;
-
optional int64 creation_time_us = 4;
-
optional int64 update_time_us = 5;
+ optional int64 first_read_time_us = 11;
gambard 2016/11/28 17:33:51 It makes sense to regroup the fields by usage (i.e
Olivier 2016/11/28 17:59:15 It is like that in other specifics, so I guess it
enum ReadingListEntryStatus {
UNREAD = 0;
« no previous file with comments | « no previous file | components/sync/protocol/reading_list_specifics.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698