Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2534893002: [runtime] Simplify handler table lookup semantics. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Simplify handler table lookup semantics. The range-based exception handler table is by now only used for bytecode arrays. The semantics of the interpreter are that bytecode offsets point to the beginning of the currently executing bytecode instruction. Uses hence need to compensate for lookups based on a "retrun address". This change removes the need for such off-by-one compensations by changing lookup semantics to be based on "current instruction" offsets. R=jarin@chromium.org Committed: https://crrev.com/7a82d8e9e4d7e3ec46d9436262ff13afa0ef2304 Cr-Commit-Position: refs/heads/master@{#41339}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M src/deoptimizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/frames.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/objects.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Michael Starzinger
4 years ago (2016-11-28 13:14:47 UTC) #1
Jarin
Nice! lgtm.
4 years ago (2016-11-28 13:37:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534893002/1
4 years ago (2016-11-28 13:49:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534893002/20001
4 years ago (2016-11-29 09:15:06 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 09:16:47 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-29 09:17:15 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a82d8e9e4d7e3ec46d9436262ff13afa0ef2304
Cr-Commit-Position: refs/heads/master@{#41339}

Powered by Google App Engine
This is Rietveld 408576698