Sandbox the component updater's patcher utility process.

courgette/third_party/bsdiff/bsdiff.h

 // Copyright 2003, 2004 Colin Percival
 // All rights reserved
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted providing that the following conditions
 // are met:
 // 1. Redistributions of source code must retain the above copyright
 //    notice, this list of conditions and the following disclaimer.
 // 2. Redistributions in binary form must reproduce the above copyright
 //    notice, this list of conditions and the following disclaimer in the
@@ skipping 28 matching lines @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COURGETTE_THIRD_PARTY_BSDIFF_BSDIFF_H_
 #define COURGETTE_THIRD_PARTY_BSDIFF_BSDIFF_H_
 
 #include <stdint.h>
 
 #include "base/files/file_util.h"
 
+namespace base {

[huangs, 2016/12/06 18:23:22]

You're not using File pointers, and looks like this works because file_util.h
includes file.h? Please:
- Remove the forward declaration here.
- #include "base/files/file.h"
- Remove the #include from bsdiff_apply.cc.

[waffles, 2016/12/06 19:18:45]

Done.

+class File;
+}  // namespace base
+
 namespace courgette {
 class SourceStream;
 class SinkStream;
 }  // namespace courgette
 
 namespace bsdiff {
 
 enum BSDiffStatus {
   OK = 0,
   MEM_ERROR = 1,
@@ skipping 15 matching lines @@
 //
 BSDiffStatus ApplyBinaryPatch(courgette::SourceStream* old_stream,
                               courgette::SourceStream* patch_stream,
                               courgette::SinkStream* new_stream);
 
 // As above, but simply takes the file paths.
 BSDiffStatus ApplyBinaryPatch(const base::FilePath& old_stream,
                               const base::FilePath& patch_stream,
                               const base::FilePath& new_stream);
 
+// As above, but simply takes base::Files.

[huangs, 2016/12/06 18:10:40]

Please move this between the Stream version and FilePath version. Same in the
.cc file.

[waffles, 2016/12/06 19:18:45]

Done.

+BSDiffStatus ApplyBinaryPatch(base::File old_stream,
+                              base::File patch_stream,
+                              base::File new_stream);
+
 // The following declarations are common to the patch-creation and
 // patch-application code.
 
 // The patch stream starts with a MBSPatchHeader.
 typedef struct MBSPatchHeader_ {
   char tag[8];      // Contains MBS_PATCH_HEADER_TAG.
   uint32_t slen;    // Length of the file to be patched.
   uint32_t scrc32;  // CRC32 of the file to be patched.
   uint32_t dlen;    // Length of the result file.
 } MBSPatchHeader;
 
 // This is the value for the tag field.  Must match length exactly, not counting
 // null at end of string.
 #define MBS_PATCH_HEADER_TAG "GBSDIF42"
 
 }  // namespace bsdiff
 
 #endif  // COURGETTE_THIRD_PARTY_BSDIFF_BSDIFF_H_